DEV-78 - Allow specifying certificate file names #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w1am
force-pushed
the
w1am/dev-78-allow-specifying-certificate-file-names
branch
from
e6fec73 to
b5955ee
Compare
w1am
force-pushed
the
w1am/dev-78-allow-specifying-certificate-file-names
branch
5 times, most recently
from
d44d42e to
45debe6
Compare
- Add tests for `create-certs` command - Improve test coverage - Some refactoring - Fix linting issues
josephcummings
force-pushed
the
w1am/dev-78-allow-specifying-certificate-file-names
branch
from
45debe6 to
fde644b
Compare
josephcummings
force-pushed
the
w1am/dev-78-allow-specifying-certificate-file-names
branch
from
fde644b to
1e621e4
Compare
josephcummings
changed the title
cdevarenne
approved these changes
Mar 20, 2024
w1am
force-pushed
the
w1am/dev-78-allow-specifying-certificate-file-names
branch
from
f61774f to
c048064
Compare
w1am
force-pushed
the
w1am/dev-78-allow-specifying-certificate-file-names
branch
from
c048064 to
0415a77
Compare
josephcummings
approved these changes
Mar 22, 2024
josephcummings
deleted the
w1am/dev-78-allow-specifying-certificate-file-names
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #15
Added: Allow specifying certificate file names in create-ca, create-user, create-node and create-certs
Added: Tests for the create_certs command, which previously did not exist. It was included in the same PR in order to test the -name flag.
Notable Changes
Allow specifying certificate file names in
create-ca,create-user,create-nodeandcreate-certsusing the-nameflag and name key increate_certs.Improved test coverage
Rewrote the tests to make them more readable. Now, instead of testing the tool by calling the method directly, we can run the test using
Run()and manually pass the arguments. Added test for intermediate certificate, certificates default validity period, name flag, test with different output directory and create certs command with different configs; invalid paths, name key and force flag.