Skip to content

chore: remove deprecated 'pretrained_model_name' parameter#8

Merged
Tohrusky merged 3 commits intoEutropicAI:mainfrom
TohruskyDev:main
Sep 27, 2025
Merged

chore: remove deprecated 'pretrained_model_name' parameter#8
Tohrusky merged 3 commits intoEutropicAI:mainfrom
TohruskyDev:main

Conversation

@Tohrusky
Copy link
Member

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @Tohrusky, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on cleaning up the codebase by eliminating legacy support for a deprecated parameter, 'pretrained_model_name'. The changes simplify the from_pretrained function by removing the conditional logic that handled this parameter and also removes the no longer required warnings module import, contributing to a more streamlined and maintainable system.

Highlights

  • Deprecated Parameter Removal: The handling logic for the deprecated 'pretrained_model_name' parameter has been completely removed from the from_pretrained function in cccv/auto/config.py.
  • Code Cleanup: The warnings module import, which was previously used for the deprecation notice, has been removed from cccv/auto/config.py as it is no longer needed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the deprecated pretrained_model_name parameter. The changes are correct and achieve this goal. However, I have one suggestion to improve the user experience around this breaking change. Instead of silently ignoring the old parameter, it would be more helpful to raise an error to explicitly notify users that they need to update their code. The other minor code cleanup looks fine.

@Tohrusky Tohrusky merged commit a375996 into EutropicAI:main Sep 27, 2025
9 checks passed
@codecov
Copy link

codecov bot commented Sep 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.76%. Comparing base (6e85a15) to head (07e7ec0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   92.62%   92.76%   +0.14%     
==========================================
  Files          40       40              
  Lines        1220     1216       -4     
==========================================
- Hits         1130     1128       -2     
+ Misses         90       88       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments