Skip to content

test: skip download proxy test on CI#6

Merged
Tohrusky merged 3 commits intoEutropicAI:mainfrom
TohruskyDev:main
Sep 26, 2025
Merged

test: skip download proxy test on CI#6
Tohrusky merged 3 commits intoEutropicAI:mainfrom
TohruskyDev:main

Conversation

@Tohrusky
Copy link
Member

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @Tohrusky, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily optimizes CI test execution by skipping a specific download proxy test (test_cache_models_with_gh_proxy) when running in CI environments, thereby reducing bandwidth consumption. Additionally, it includes a minor correction in the Makefile to ensure the correct file extension (.mp4 instead of .mkv) is targeted for removal in the vs build step.

Highlights

  • CI Test Optimization: The test_cache_models_with_gh_proxy test is now configured to be skipped when running in a Continuous Integration (CI) environment. This change aims to conserve bandwidth for the CI provider by avoiding unnecessary downloads during automated test runs.
  • Makefile Correction: The Makefile has been updated to correctly remove encoded.mp4 instead of encoded.mkv in the vs target, likely fixing a file extension mismatch.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request makes two beneficial changes. First, it correctly skips a network-intensive test involving a download proxy during CI runs, which is a good practice to conserve resources. This is implemented cleanly using pytest.mark.skipif. Second, it fixes a minor bug in the Makefile by correcting a filename in a rm command to match the output file generated by ffmpeg. Both changes are well-executed and improve the repository.

@Tohrusky Tohrusky merged commit 80fefa4 into EutropicAI:main Sep 26, 2025
9 checks passed
@codecov
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.61%. Comparing base (1ad50b0) to head (3a10d8a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   92.94%   92.61%   -0.33%     
==========================================
  Files          40       40              
  Lines        1219     1219              
==========================================
- Hits         1133     1129       -4     
- Misses         86       90       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments