Skip to content

Remove Google Analytics / tracking #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joshvanvliet wants to merge 2 commits into from
Closed

Remove Google Analytics / tracking #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb22bef
Remove Google Analytics/tracking
joshvanvliet Jun 10, 2026
9efae55
Cleanup
joshvanvliet Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 0 additions & 78 deletions apps/common/Analytics.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion apps/documenteditor/embed/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,6 @@
<!--application-->
<script type="text/javascript" src="../../common/locale.js"></script>
<script type="text/javascript" src="../../common/Gateway.js"></script>
<script type="text/javascript" src="../../common/Analytics.js"></script>
<script type="text/javascript" src="../../common/main/lib/mods/dropdown.js"></script>
<script type="text/javascript" src="../../common/main/lib/mods/modal.js"></script>
<script type="text/javascript" src="../../common/main/lib/mods/tooltip.js"></script>
Expand Down
1 change: 0 additions & 1 deletion apps/documenteditor/embed/index_loader.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,6 @@
<!--application-->
<script type="text/javascript" src="../../common/locale.js"></script>
<script type="text/javascript" src="../../common/Gateway.js"></script>
<script type="text/javascript" src="../../common/Analytics.js"></script>
<script type="text/javascript" src="../../common/embed/lib/util/LocalStorage.js"></script>
<script type="text/javascript" src="../../common/embed/lib/util/utils.js"></script>
<script type="text/javascript" src="../../common/embed/lib/util/htmlutils.js"></script>
Expand Down
15 changes: 1 addition & 14 deletions apps/documenteditor/embed/js/ApplicationController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,6 @@ DE.ApplicationController = new(function(){
var LoadingDocument = -256,
WarningShown = false;

// Initialize analytics
// -------------------------

// Common.Analytics.initialize('UA-12442749-13', 'Embedded Document Editor');


// Check browser
// -------------------------

Expand Down Expand Up @@ -157,7 +151,6 @@ DE.ApplicationController = new(function(){
api.asc_getEditorPermissions(config.licenseUrl, config.customerId);
api.asc_enableKeyEvents(true);

Common.Analytics.trackEvent('Load', 'Start');
}

embedConfig.docTitle = docConfig.title;
Expand Down Expand Up @@ -520,14 +513,12 @@ DE.ApplicationController = new(function(){
common.utils.openLink(embedConfig.saveUrl);
}

Common.Analytics.trackEvent('Save');
});

DE.ApplicationView.tools.get('#idt-print')
.on('click', function(){
var printCallback = function() {
api.asc_Print(new Asc.asc_CDownloadOptions(null, $.browser.chrome || $.browser.safari || $.browser.opera || $.browser.mozilla && $.browser.versionNumber>86));
Common.Analytics.trackEvent('Print');
};

var submitPassword = function(val) {
Expand Down Expand Up @@ -566,7 +557,6 @@ DE.ApplicationController = new(function(){

var downloadAs = function(format){
api.asc_DownloadAs(new Asc.asc_CDownloadOptions(format));
Common.Analytics.trackEvent('Save');
};

DE.ApplicationView.tools.get('#idt-download-docx')
Expand Down Expand Up @@ -677,7 +667,6 @@ DE.ApplicationController = new(function(){
}

Common.Gateway.documentReady();
Common.Analytics.trackEvent('Load', 'Complete');
requireUserAction = false;
}

Expand Down Expand Up @@ -961,7 +950,6 @@ DE.ApplicationController = new(function(){
Common.Gateway.reportWarning(id, message);
}

Common.Analytics.trackEvent('Internal Error', id.toString());
}

function onExternalMessage(error) {
Expand All @@ -971,7 +959,6 @@ DE.ApplicationController = new(function(){
$('#id-error-mask-text').text(error.msg);
$('#id-error-mask').css('display', 'block');

Common.Analytics.trackEvent('External Error');
}
}

Expand Down Expand Up @@ -1225,4 +1212,4 @@ DE.ApplicationController = new(function(){
txtSecurityWarningLinkOk: 'This document is trying to connect to %1.<br>If you trust this site, press \"OK\".',
errorCopyDisabled: 'For security reasons, the contents of this document cannot be copied to the clipboard.'
}
})();
})();
7 changes: 0 additions & 7 deletions apps/documenteditor/forms/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ require.config({
keymaster : 'common/main/lib/core/keymaster',
tip : 'common/main/lib/util/Tip',
localstorage : 'common/main/lib/util/LocalStorage',
analytics : 'common/Analytics',
gateway : 'common/Gateway',
locale : 'common/locale',
irregularstack : 'common/IrregularStack'
Expand Down Expand Up @@ -91,11 +90,6 @@ require.config({
'jquery'
]
},
analytics: {
deps: [
'jquery'
]
}
}
});

Expand All @@ -105,7 +99,6 @@ require([
'underscore',
'core',
'api',
'analytics',
'gateway',
'locale'
], function (Sdk, Backbone, _, Core) {
Expand Down
12 changes: 0 additions & 12 deletions apps/documenteditor/forms/app/controller/ApplicationController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,8 +423,6 @@ define([

if (!Common.Utils.ModalWindow.isVisible() || $('.asc-window.modal.alert[data-value="' + id + '"]').length<1)
Common.UI.alert(config).$window.attr('data-value', id);

(id!==undefined) && Common.component.Analytics.trackEvent('Internal Error', id.toString());
},

hidePreloader: function() {
Expand Down Expand Up @@ -533,8 +531,6 @@ define([
if (msg && msg.msg) {
msg.msg = (msg.msg).toString();
this.showTips([msg.msg.charAt(0).toUpperCase() + msg.msg.substring(1)]);

Common.component.Analytics.trackEvent('External Error');
}
},

Expand Down Expand Up @@ -627,8 +623,6 @@ define([
this.api.asc_setDocInfo(docInfo);
this.api.asc_getEditorPermissions(this.editorConfig.licenseUrl, this.editorConfig.customerId);
this.api.asc_enableKeyEvents(true);

Common.Analytics.trackEvent('Load', 'Start');
},

onRunAutostartMacroses: function() {
Expand Down Expand Up @@ -1164,7 +1158,6 @@ define([

if (this.api)
this.api.asc_Print(new Asc.asc_CDownloadOptions(null, Common.Utils.isChrome || Common.Utils.isOpera || Common.Utils.isGecko && Common.Utils.firefoxVersion>86)); // if isChrome or isOpera == true use asc_onPrintUrl event
Common.component.Analytics.trackEvent('Print');
},

onPrintUrl: function(url) {
Expand Down Expand Up @@ -1677,7 +1670,6 @@ define([
this.attachUIEvents();

Common.Gateway.documentReady();
Common.Analytics.trackEvent('Load', 'Complete');
Common.NotificationCenter.trigger('document:ready');
Common.UI.TooltipManager.showTip('showFillStatus');
requireUserAction = false;
Expand All @@ -1703,11 +1695,9 @@ define([
} else if (this.api && this.appOptions.canPrint){
this.api.asc_Print(new Asc.asc_CDownloadOptions(null, Common.Utils.isChrome || Common.Utils.isOpera || Common.Utils.isGecko && Common.Utils.firefoxVersion>86)); // if isChrome or isOpera == true use asc_onPrintUrl event
}
Common.Analytics.trackEvent('Save');
break;
case 'print':
this.api.asc_Print(new Asc.asc_CDownloadOptions(null, Common.Utils.isChrome || Common.Utils.isOpera || Common.Utils.isGecko && Common.Utils.firefoxVersion>86)); // if isChrome or isOpera == true use asc_onPrintUrl event
Common.Analytics.trackEvent('Print');
break;
case 'close':
if (!Common.Controllers.Desktop.process('goback') &&
Expand All @@ -1726,11 +1716,9 @@ define([
break;
case 'download-docx':
this.api.asc_DownloadAs(new Asc.asc_CDownloadOptions(Asc.c_oAscFileType.DOCX));
Common.Analytics.trackEvent('Save');
break;
case 'download-pdf':
this.api.asc_DownloadAs(new Asc.asc_CDownloadOptions(Asc.c_oAscFileType.PDF));
Common.Analytics.trackEvent('Save');
break;
case 'share':
(new Common.Views.ShareDialog({
Expand Down
7 changes: 0 additions & 7 deletions apps/documenteditor/forms/app_dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ require.config({
keymaster : 'common/main/lib/core/keymaster',
tip : 'common/main/lib/util/Tip',
localstorage : 'common/main/lib/util/LocalStorage',
analytics : 'common/Analytics',
gateway : 'common/Gateway',
locale : 'common/locale',
irregularstack : 'common/IrregularStack'
Expand Down Expand Up @@ -80,11 +79,6 @@ require.config({
'jquery'
]
},
analytics: {
deps: [
'jquery'
]
}
}
});

Expand All @@ -93,7 +87,6 @@ require([
'underscore',
'core',
'api',
'analytics',
'gateway',
'locale',
'socketio',
Expand Down
7 changes: 0 additions & 7 deletions apps/documenteditor/main/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ require.config({
keymaster : 'common/main/lib/core/keymaster',
tip : 'common/main/lib/util/Tip',
localstorage : 'common/main/lib/util/LocalStorage',
analytics : 'common/Analytics',
gateway : 'common/Gateway',
locale : 'common/locale',
irregularstack : 'common/IrregularStack'
Expand Down Expand Up @@ -96,11 +95,6 @@ require.config({
'jquery'
]
},
analytics: {
deps: [
'jquery'
]
}
}
});

Expand All @@ -109,7 +103,6 @@ require([
'backbone',
'underscore',
'core',
'analytics',
'gateway',
'locale'
], function (Sdk, Backbone, _, Core) {
Expand Down
9 changes: 0 additions & 9 deletions apps/documenteditor/main/app/controller/DocumentHolderExt.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,6 @@ define([], function () {
win.setSettings(props);
}
}
Common.component.Analytics.trackEvent('DocumentHolder', 'Add Hyperlink');
}
};

Expand Down Expand Up @@ -2014,8 +2013,6 @@ define([], function () {

win.show();
win.setSettings(item.hyperProps.value);

Common.component.Analytics.trackEvent('DocumentHolder', 'Add Hyperlink');
}
};

Expand Down Expand Up @@ -2200,7 +2197,6 @@ define([], function () {
opts.asc_setAdvancedOptions(printopt);
this.api.asc_Print(opts);
this.editComplete();
Common.component.Analytics.trackEvent('DocumentHolder', 'Print Selection');
}
};

Expand Down Expand Up @@ -2456,13 +2452,10 @@ define([], function () {
value = (alignto==1) ? Asc.c_oAscObjectsAlignType.Page : ((me.api.asc_getSelectedDrawingObjectsCount()<2 && !alignto || alignto==2) ? Asc.c_oAscObjectsAlignType.Margin : Asc.c_oAscObjectsAlignType.Selected);
if (item.value < 6) {
me.api.put_ShapesAlign(item.value, value);
Common.component.Analytics.trackEvent('DocumentHolder', 'Shape Align');
} else if (item.value == 6) {
me.api.DistributeHorizontally(value);
Common.component.Analytics.trackEvent('DocumentHolder', 'Distribute Horizontally');
} else if (item.value == 7){
me.api.DistributeVertically(value);
Common.component.Analytics.trackEvent('DocumentHolder', 'Distribute Vertically');
}
}
me.editComplete();
Expand All @@ -2472,7 +2465,6 @@ define([], function () {
var me = this;
if (item && item.value) {
me.api.asc_mergeSelectedShapes(item.value);
Common.component.Analytics.trackEvent('DocumentHolder', 'Shapes Merge');
}
me.editComplete();
};
Expand Down Expand Up @@ -2640,7 +2632,6 @@ define([], function () {
if (me.api) {
me.api.SplitCell(value.columns, value.rows);
}
Common.component.Analytics.trackEvent('DocumentHolder', 'Table');
}
me.editComplete();
}
Expand Down
3 changes: 0 additions & 3 deletions apps/documenteditor/main/app/controller/HeaderFooterTab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ define([
setTimeout(function() {me.api.asc_addImage();}, 1);

Common.NotificationCenter.trigger('edit:complete', me.view);
// Common.component.Analytics.trackEvent('ToolBar', 'Image');
} else if (item.value === 'url') {
(new Common.Views.ImageFromUrlDialog({
handler: function(result, value) {
Expand All @@ -96,8 +95,6 @@ define([
if (!_.isEmpty(checkUrl)) {
me.view.fireEvent('insertimage');
me.api.AddImageUrl([checkUrl]);

// Common.component.Analytics.trackEvent('ToolBar', 'Image');
}
}

Expand Down
Loading