WIP: refactor(mobile): split shared editor.jsx into focused modules - #217
Draft
moodyjmz wants to merge 1 commit into
Draft
WIP: refactor(mobile): split shared editor.jsx into focused modules#217moodyjmz wants to merge 1 commit into
moodyjmz wants to merge 1 commit into
Conversation
Extract toolbar icons, theme init, and PlatformIcon/ToolbarIconLink components out of common/mobile/lib/editor.jsx into standalone modules, and split each editor's context-menu focus-object logic into focusObjectTags/selectionRules with unit test coverage. Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP / draft — not ready for review.
Splits
apps/common/mobile/lib/editor.jsxinto focused modules (icons.js,PlatformIcon.jsx,ToolbarIconLink.jsx,toolbarIcons.js,getTopFocusObject.js,initThemeColors.js) plus per-editor focus-object test coverage, and restores Ascensio headers + a Euro-Office modification notice on the foureditor.jsxfiles that had dropped them.Opened as draft mainly to get this off local-only storage — it's been sitting as a single unpushed commit. No further changes pushed yet.