Skip to content

fix: scale converter workers with CPU count - #31

Merged
juliusknorr merged 1 commit into
mainfrom
fix/converter-workers-no-license-cap
Jun 18, 2026
Merged

fix: scale converter workers with CPU count#31
juliusknorr merged 1 commit into
mainfrom
fix/converter-workers-no-license-cap

Conversation

@juliusknorr

@juliusknorr juliusknorr commented Jun 18, 2026

Copy link
Copy Markdown
Member

The FileConverter worker cluster was clamped to licenseInfo.count, which is hardcoded to 1 in the open-source license.js. As a result FileConverter.converter.maxprocesscount and the CPU count had no effect and only a single converter worker ever started, serializing all conversions.

This matches upstream ONLYOFFICE/DocumentServer#2594.

Change

  • Remove the Math.min(licenseInfo.count, workersCount) cap in FileConverter/sources/convertermaster.js.
  • Drop the license dependency from this file along with the now-pointless license-file watch and daily re-read (worker count only depends on CPU count and config, both static for the process lifetime).

Worker count now derives solely from availableParallelism (falling back to CPU count) and maxprocesscount. license.js itself is left untouched as it is used elsewhere.

@juliusknorr juliusknorr added the bug Something isn't working label Jun 18, 2026
@juliusknorr
juliusknorr requested review from DmySyz, chrip and rikled June 18, 2026 12:41
The FileConverter cluster was clamped to licenseInfo.count, which is
hardcoded to 1, so maxprocesscount and CPU count had no effect and only
a single converter worker ever started. Drop the license-based cap (and
the now-pointless license file watch/daily re-read) so worker count
derives solely from availableParallelism and maxprocesscount.

Assisted-by: ClaudeCode:claude-opus-4-8
Signed-off-by: Julius Knorr <jus@bitgrid.net>
@juliusknorr
juliusknorr force-pushed the fix/converter-workers-no-license-cap branch from 94304ee to f90636d Compare June 18, 2026 12:44
@juliusknorr juliusknorr self-assigned this Jun 18, 2026
@juliusknorr juliusknorr added the nc-report Nextcloud testing reports label Jun 18, 2026
@juliusknorr juliusknorr moved this from 📄 To do to 👀 In review in 📄 Euro-Office team Jun 18, 2026
@juliusknorr
juliusknorr merged commit 79e4ec4 into main Jun 18, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In review to ☑️ Done in 📄 Euro-Office team Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working nc-report Nextcloud testing reports

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

2 participants