fix: show Euro-Office logo in custom title bar - #39
Open
adamcolwell wants to merge 2 commits into
Open
Conversation
added 2 commits
August 8, 2026 21:02
After rebranding, the title-bar main button still loaded the legacy ONLYOFFICE sprite :/logo.svg with logo-light/logo-dark nodes. That resource is not registered in resources.qrc, so CSVGPushButton failed to open the file and left the button blank (hit target still worked). QSS already references the packaged :/logo-*-eo.svg assets, but updateScaling/applyTheme override qproperty-icon from C++. Point those call sites at logo-light-eo.svg / logo-dark-eo.svg instead.
The previous logo-*-eo.svg assets used nested <svg> plus <text>. Qt's QSvgRenderer (used by CSVGPushButton and QSS image:url) does not reliably draw those, so the title-bar mark stayed blank even after the resource path fix. Regenerate light/dark logos as single-path wordmarks (Noto Sans outlines + document icon), refresh PNG fallbacks, and keep C++ pointed at the packaged :/logo-*-eo.svg resources.
Author
|
Follow-up pushed: the old |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toolButtonMain) was blank because C++ still loads the legacy ONLYOFFICE resource:/logo.svg(withlogo-light/logo-darknodes).resources.qrcafter the Euro-Office rebrand; onlylogo-light-eo/logo-dark-eo(svg/png) are packaged.qproperty-icon, butCMainPanelImpl::updateScaling/applyThemeoverride the icon from C++ and wipe it when the open fails.Change
:/logo-light-eo.svg/:/logo-dark-eo.svg(no sprite node) and size the icon to the EO SVG viewBox (83×20).Test plan