Skip to content

fix(v8): pin depot_tools so gclient_paths.patch applies #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DmySyz merged 1 commit into from
Jul 24, 2026
Merged

fix(v8): pin depot_tools so gclient_paths.patch applies #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions Common/3dParty/v8/nc-build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,13 +371,22 @@ def fetch_and_patch():
"Clone depot_tools"
)

# Update depot_tools
# Pin depot_tools to a known-good revision instead of tracking HEAD.
# depot_tools main moves; commit f065bb3b0 (2026-07-13, "Add gclient getconfig
# subcommand") reworked gclient_paths.py so gclient_paths.patch no longer
# applies. 6e5a13d2 (2026-06-22) is the newest revision it applies against —
# pin it so the V8 build is reproducible and immune to depot_tools drift.
nc.run_command(
[ "git", "pull", "origin", "main" ],
"Update depot_tools",
[ "git", "fetch", "--quiet", "origin" ],
"Fetch depot_tools",
depot_tools_path,
error_is_fatal = False
)
nc.run_command(
[ "git", "checkout", "--force", "--detach", "6e5a13d2598ee48c9c7afc750401533f30dde16e" ],
"Pin depot_tools to known-good revision",
depot_tools_path
)

# Fetch v8
print( "Fetching v8" )
Expand Down Expand Up @@ -431,6 +440,9 @@ def build_and_install():
depot_env["GCLIENT_SUPPRESS_GIT_VERSION_WARNING"] = "1"
depot_env["GYP_CHROMIUM_NO_ACTION"] = "1"
depot_env["DEPOT_TOOLS_WIN_TOOLCHAIN"] = "0"
# Keep depot_tools from self-updating to HEAD during sync, which would undo
# the pin in fetch_and_patch() and re-break gclient_paths.patch.
depot_env["DEPOT_TOOLS_UPDATE"] = "0"

if nc.is_windows():
fake_pipes_shim_path = create_fake_pipes_shim()
Expand Down
Loading