Conversation
…ed workflow steps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to improve functionality, readability, and reliability in the bug reproduction workflow and related modules. Key changes include enhancements to the
BugReproductionSubgraphclass, stricter type handling, and documentation improvements. Below is a categorized summary of the most important changes:Enhancements to the Bug Reproduction Workflow:
BugReproductionSubgraphclass to clarify its purpose and workflow. This includes describing each step of the state machine, such as context retrieval, patch writing, file editing, and retry loops. ([[1]](https://github.com/EuniAI/Prometheus/pull/94/files#diff-df7971631d9eb7557c9e2f62d2893a67accdb61fd727ffc1dcfb5400620852b2R31-R36),[[2]](https://github.com/EuniAI/Prometheus/pull/94/files#diff-df7971631d9eb7557c9e2f62d2893a67accdb61fd727ffc1dcfb5400620852b2R48-R66),[[3]](https://github.com/EuniAI/Prometheus/pull/94/files#diff-df7971631d9eb7557c9e2f62d2893a67accdb61fd727ffc1dcfb5400620852b2R76-R99),[[4]](https://github.com/EuniAI/Prometheus/pull/94/files#diff-df7971631d9eb7557c9e2f62d2893a67accdb61fd727ffc1dcfb5400620852b2R108-L94),[[5]](https://github.com/EuniAI/Prometheus/pull/94/files#diff-df7971631d9eb7557c9e2f62d2893a67accdb61fd727ffc1dcfb5400620852b2R151-R159))invokemethod inBugReproductionSubgraphto 100, allowing for deeper retries in complex scenarios. ([prometheus/lang_graph/subgraphs/bug_reproduction_subgraph.pyL188-L201](https://github.com/EuniAI/Prometheus/pull/94/files#diff-df7971631d9eb7557c9e2f62d2893a67accdb61fd727ffc1dcfb5400620852b2L188-L201))[[1]](https://github.com/EuniAI/Prometheus/pull/94/files#diff-df7971631d9eb7557c9e2f62d2893a67accdb61fd727ffc1dcfb5400620852b2R195-R232),[[2]](https://github.com/EuniAI/Prometheus/pull/94/files#diff-df7971631d9eb7557c9e2f62d2893a67accdb61fd727ffc1dcfb5400620852b2R169-R170))Type and Dependency Handling:
added_test_filenamemethod inBugReproducingExecuteNodefromstrtoPathfor better type safety. ([prometheus/lang_graph/nodes/bug_reproducing_execute_node.pyL70-R74](https://github.com/EuniAI/Prometheus/pull/94/files#diff-c64259bf32f9f57dc56a11e422e1ca234696beec0592eb66d1db66c6ccd9c8f2L70-R74))__call__method inBugReproducingExecuteNodeto explicitly convertPathobjects to strings when formatting messages. ([prometheus/lang_graph/nodes/bug_reproducing_execute_node.pyL111-R115](https://github.com/EuniAI/Prometheus/pull/94/files#diff-c64259bf32f9f57dc56a11e422e1ca234696beec0592eb66d1db66c6ccd9c8f2L111-R115))Documentation and Comments:
__init__andinvokemethods ofBugReproductionSubgraph, explaining arguments, steps, and expected outputs. ([[1]](https://github.com/EuniAI/Prometheus/pull/94/files#diff-df7971631d9eb7557c9e2f62d2893a67accdb61fd727ffc1dcfb5400620852b2R48-R66),[[2]](https://github.com/EuniAI/Prometheus/pull/94/files#diff-df7971631d9eb7557c9e2f62d2893a67accdb61fd727ffc1dcfb5400620852b2L188-L201))context_extraction_node.pyfile to specify constraints on line numbers. ([prometheus/lang_graph/nodes/context_extraction_node.pyL54-R55](https://github.com/EuniAI/Prometheus/pull/94/files#diff-ba139c0232c524325719a0168e1d99d2d675607a83833374722a978b37865bebL54-R55))Bug Fixes:
BugReproducingExecuteNodeclass comments, changing "EXECTUTE" to "EXECUTE" and adjusted rules to explicitly note that dependencies may need to be installed. ([prometheus/lang_graph/nodes/bug_reproducing_execute_node.pyL25-R32](https://github.com/EuniAI/Prometheus/pull/94/files#diff-c64259bf32f9f57dc56a11e422e1ca234696beec0592eb66d1db66c6ccd9c8f2L25-R32))Cleanup and Minor Adjustments:
GraphRecursionError) frombug_reproduction_subgraph.pyto clean up the codebase. ([prometheus/lang_graph/subgraphs/bug_reproduction_subgraph.pyL6](https://github.com/EuniAI/Prometheus/pull/94/files#diff-df7971631d9eb7557c9e2f62d2893a67accdb61fd727ffc1dcfb5400620852b2L6))invokemethod ofissue_verified_bug_subgraph.pyto align with changes in related modules. ([prometheus/lang_graph/subgraphs/issue_verified_bug_subgraph.pyL188-R188](https://github.com/EuniAI/Prometheus/pull/94/files#diff-13234819dbfca353a2a941f3fccd3b0f6950bbca52c25635c57ac26652333d9bL188-R188))Issue Resolved
Resolved issue #93