GH-347 Add lightning effect on player death and settings

[CitralFlo]

[gemini-code-assist]

Summary of Changes

Hello @CitralFlo, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new, configurable visual effect for player deaths within the combat plugin. Players will now trigger a lightning strike at their location upon death, which can be toggled on or off via the plugin's configuration file. This change aims to provide a more dynamic and impactful experience during combat encounters.

Highlights

• New Feature: Lightning Effect on Player Death: Implemented a new feature that causes a lightning strike effect when a player dies, enhancing visual feedback during combat.
• Configurable Death Effects: Introduced a new configuration section, DeathSettings, allowing server administrators to enable or disable the lightning effect on player death.
• Dedicated Controller for Death Effects: Added a DeathEffectController to manage the logic for applying visual effects upon player death, ensuring modularity and maintainability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• eternalcombat-plugin/src/main/java/com/eternalcode/combat/CombatPlugin.java
  • Imported the new DeathEffectController class.
  • Registered an instance of DeathEffectController in the plugin's onEnable method.
• eternalcombat-plugin/src/main/java/com/eternalcode/combat/config/implementation/PluginConfig.java
  • Imported the new DeathSettings class.
  • Added a new death field of type DeathSettings to the plugin's main configuration, including comments for clarity.
• eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/death/DeathEffectController.java
  • Added a new class DeathEffectController responsible for handling player death events.
  • Implemented an @EventHandler method to strike lightning at the player's location if the lightning setting is enabled in the plugin configuration.
• eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/death/DeathSettings.java
  • Added a new class DeathSettings to define configuration options related to player death effects.
  • Included a lightning boolean field, defaulting to true, to control the lightning strike effect.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a lightning effect upon player death, with a configuration option to enable or disable it. The implementation is straightforward and correct. I've suggested a small refactoring to improve decoupling by injecting the specific settings class (DeathSettings) into the DeathEffectController instead of the entire PluginConfig. This will make the code more maintainable and easier to test in the future.

[vLuckyyy]

Can you add gif to readme?

[CitralFlo]

Can you add gif to readme?

sure, after work will do

[igoyek]

Loooks crazy 😃