Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,15 @@
import java.util.Optional;
import org.bukkit.Location;
import org.bukkit.Server;
import org.bukkit.entity.Entity;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerMoveEvent;
import org.bukkit.event.player.PlayerTeleportEvent;
import org.bukkit.event.vehicle.VehicleMoveEvent;
import org.spigotmc.event.entity.EntityMountEvent;

public class KnockbackRegionController implements Listener {

Expand Down Expand Up @@ -89,6 +92,68 @@ void onPlayerTeleport(PlayerTeleportEvent event) {
}
}

@EventHandler(ignoreCancelled = true, priority = EventPriority.HIGHEST)
void onVehicleMove(VehicleMoveEvent event) {
Location locationTo = event.getTo();
Location locationFrom = event.getFrom();

if (locationTo.getBlockX() == locationFrom.getBlockX()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to method?

&& locationTo.getBlockY() == locationFrom.getBlockY()
&& locationTo.getBlockZ() == locationFrom.getBlockZ()) {
return;
}

Optional<Region> regionOptional = this.regionProvider.getRegion(locationTo);
if (regionOptional.isEmpty()) {
return;
}

Region region = regionOptional.get();
for (Entity passenger : event.getVehicle().getPassengers()) {
if (!(passenger instanceof Player player)) {
continue;
}

if (!this.fightManager.isInCombat(player.getUniqueId())) {
continue;
}

player.leaveVehicle();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
player.leaveVehicle();

Already in knockback()

if (region.contains(locationFrom)) {
this.knockbackService.knockback(region, player);
this.knockbackService.forceKnockbackLater(player, region);
} else {
this.knockbackService.knockbackLater(region, player, Duration.ofMillis(50));
}
Comment on lines +122 to +127
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this could be exctracted? or even optimized


this.noticeService.create()
.player(player.getUniqueId())
.notice(config -> config.messagesSettings.cantEnterOnRegion)
.send();
}
}

@EventHandler(ignoreCancelled = true, priority = EventPriority.HIGHEST)
void onEntityMount(EntityMountEvent event) {
if (!(event.getEntity() instanceof Player player)) {
return;
}

if (!this.fightManager.isInCombat(player.getUniqueId())) {
return;
}

if (!this.regionProvider.isInRegion(event.getMount().getLocation())) {
return;
}

event.setCancelled(true);
this.noticeService.create()
.player(player.getUniqueId())
.notice(config -> config.messagesSettings.cantEnterOnRegion)
.send();
}
Comment on lines +96 to +155
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

The current implementation lacks handling for EntityTeleportEvent and VehicleTeleportEvent. If an entity (like a horse or a boat) carrying a player in combat is teleported into a restricted region (e.g., via a portal, a command, or another plugin's feature), the player will enter the region without triggering the knockback logic. This allows players to bypass combat region restrictions. It is recommended to implement listeners for these teleportation events to ensure passengers in combat are properly knocked back when entering restricted regions.


@EventHandler(ignoreCancelled = true, priority = EventPriority.HIGHEST)
void onTag(FightTagEvent event) {
Player player = this.server.getPlayer(event.getPlayer());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ public void forceKnockbackLater(Player player, Region region) {
scheduler.runLater(
player.getLocation(), () -> {
insideRegion.remove(player.getUniqueId());
if (player.isInsideVehicle()) {
player.leaveVehicle();
}

Location playerLocation = player.getLocation();
if (!region.contains(playerLocation) && !regionProvider.isInRegion(playerLocation)) {
return;
Expand All @@ -68,6 +72,10 @@ private Location generate(Location playerLocation, Point2D minX, Point2D maxX) {
}

public void knockback(Region region, Player player) {
if (player.isInsideVehicle()) {
player.leaveVehicle();
}

Point point = region.getCenter();
Location subtract = player.getLocation().subtract(point.x(), 0, point.z());

Expand Down