Skip to content

GH-233 Add option to disable pings for users #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CitralFlo wants to merge 2 commits into
base: master
Choose a base branch
from
Open

GH-233 Add option to disable pings for users #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d7ee58
Add option to disable pings for users
CitralFlo Feb 1, 2026
92c8524
Rever miss commit
CitralFlo Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/main/java/com/eternalcode/discordapp/review/GitHubReviewNotificationType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,20 @@ public enum GitHubReviewNotificationType {

DM,
SERVER,
NONE,
BOTH;

public boolean isDmNotify() {
return switch (this) {
case DM, BOTH -> true;
case SERVER -> false;
case SERVER, NONE -> false;
};
}

public boolean isServerNotify() {
return switch (this) {
case SERVER, BOTH -> true;
case DM -> false;
case DM, NONE -> false;
};
}
}
1 change: 1 addition & 0 deletions src/main/java/com/eternalcode/discordapp/review/command/child/NotificationChild.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ public NotificationChild(GitHubReviewService gitHubReviewService) {
.addChoice("DM", GitHubReviewNotificationType.DM.toString())
.addChoice("SERVER", GitHubReviewNotificationType.SERVER.toString())
.addChoice("BOTH", GitHubReviewNotificationType.BOTH.toString())
.addChoice("NONE", GitHubReviewNotificationType.NONE.toString())
.setRequired(true)
);

Expand Down
Loading