Delivery for Reporter Instant App - Sprint1 - AGOL-2024.R01 #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Implemented following items - Loading map - Creating side panel - Layer list Following items are implemented and are still in testing: - Feature List - Feature Details (when selected feature using feature list)
jmhauck
reviewed
Jan 12, 2024
| </calcite-shell> | ||
| } | ||
| {!validConfiguration && | ||
| <calcite-notice class="error-msg" icon="configure" kind="danger" open> |
There was a problem hiding this comment.
@sumitzarkar minor thing but for consistency across the repo, if you have more than one attribute please list them on separate lines.
jmhauck
reviewed
Jan 12, 2024
|
|
||
| <!-- <body class="calcite-mode-dark"> --> | ||
| <body> | ||
| <feature-list/> |
There was a problem hiding this comment.
Please make make this functional
jmhauck
reviewed
Jan 12, 2024
|
|
||
| <!-- <body class="calcite-mode-dark"> --> | ||
| <body> | ||
| <layer-list/> |
There was a problem hiding this comment.
Please make make this functional
jmhauck
approved these changes
Jan 12, 2024
|
We have implemented above review comments, we will deilver it in the next code drop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented following items
Following items are implemented and are still in testing:
Tested on following platforms:
QA Checklist:
QAChecklist-CrowdsourceReporter_Instant_App-AGOL2024-_Sprint1.xlsx
Test cases & Execution report:
ESRILG_-TestScenarios___TestCases_-_CrowdsourceReporter_Instant_App-AGOL2024-_Sprint1.xlsx