Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(combobox-item): interactive states update color of shortHeading property #11647

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

fix(combobox-item): interactive states update color of shortHeading property #11647

wants to merge 5 commits into from
+27 −38

Conversation

anveshmekala
Copy link
Contributor

@anveshmekala anveshmekala commented Feb 27, 2025 •
edited
Loading

Related Issue: #11646

Summary

When :hover or :active, shortHeading property color is updated and synchronized with description.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Feb 27, 2025
@anveshmekala anveshmekala marked this pull request as ready for review February 28, 2025 16:53
@anveshmekala anveshmekala added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Feb 28, 2025
ashetland
ashetland requested changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@ashetland ashetland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the font weight has changed to medium across the board. All text should be regular weight. The heading text (only) should change to medium weight when selected.

@ashetland
Copy link
Contributor

Sorry, I missed this in our discussion: icons should also change to text.1 when selected.

@anveshmekala
Copy link
Contributor Author

It looks like the font weight has changed to medium across the board. All text should be regular weight. The heading text (only) should change to medium weight when selected.

This was during the initial build. Had to re build the chromatic.

@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 28, 2025
@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Mar 1, 2025
@anveshmekala anveshmekala requested a review from ashetland March 3, 2025 16:49
ashetland
ashetland approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@ashetland ashetland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anveshmekala anveshmekala requested a review from driskull March 3, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashetland ashetland ashetland approved these changes

@driskull driskull Awaiting requested review from driskull

Assignees

@anveshmekala anveshmekala

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anveshmekala @ashetland