Skip to content

Commit

Permalink
TSOnly updates
Browse files Browse the repository at this point in the history
  • Loading branch information
kellyhutchins committed Nov 12, 2019
1 parent 002147e commit 20a8991
Show file tree
Hide file tree
Showing 23 changed files with 616 additions and 523 deletions.
151 changes: 109 additions & 42 deletions ApplicationBase.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ApplicationBase.js.map

Large diffs are not rendered by default.

38 changes: 17 additions & 21 deletions ApplicationBase.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,20 @@
limitations under the License.​
*/

import kernel = require("dojo/_base/kernel");
import kernel from "dojo/_base/kernel";

import esriConfig = require("esri/config");
import esriConfig from "esri/config";

import promiseUtils = require("esri/core/promiseUtils");
import * as promiseUtils from "esri/core/promiseUtils";

import IdentityManager = require("esri/identity/IdentityManager");
import OAuthInfo = require("esri/identity/OAuthInfo");
import IdentityManager from "esri/identity/IdentityManager";
import OAuthInfo from "esri/identity/OAuthInfo";

import Portal = require("esri/portal/Portal");
import PortalItem = require("esri/portal/PortalItem");
import PortalQueryParams = require("esri/portal/PortalQueryParams");
import Portal from "esri/portal/Portal";
import PortalItem from "esri/portal/PortalItem";
import PortalQueryParams from "esri/portal/PortalQueryParams";


import declare from "./declareDecorator";
import {
Direction,
ApplicationBaseItemPromises,
Expand Down Expand Up @@ -58,7 +57,6 @@ const defaultSettings = {
webScene: {}
};

@declare()
class ApplicationBase {
//--------------------------------------------------------------------------
//
Expand Down Expand Up @@ -142,11 +140,11 @@ class ApplicationBase {
//
//--------------------------------------------------------------------------

queryGroupItems(
async queryGroupItems(
groupId: string,
itemParams: PortalQueryParams,
portal?: Portal
): IPromise<any> {
): Promise<__esri.PortalQueryResult> {
if (!portal || !groupId) {
portal = this.portal;
}
Expand All @@ -164,10 +162,11 @@ class ApplicationBase {
};

const params = new PortalQueryParams(paramOptions);
return portal.queryItems(params);
const result = await portal.queryItems(params);
return result as __esri.PortalQueryResult;
}

load(): IPromise<ApplicationBase> {
load(): Promise<ApplicationBase> {
const { settings } = this;
const {
environment: environmentSettings,
Expand All @@ -179,7 +178,6 @@ class ApplicationBase {
urlParams: urlParamsSettings
} = settings;
const { isEsri } = environmentSettings;

const urlParams = this._getUrlParamValues(urlParamsSettings);
this.results.urlParams = urlParams;

Expand Down Expand Up @@ -208,14 +206,14 @@ class ApplicationBase {
? this._loadItem(appid)
: promiseUtils.resolve();
const checkAppAccess = IdentityManager.checkAppAccess(sharingUrl, oauthappid).catch((response) => response).then((response) => { return response; });

const fetchApplicationData = appid
? loadApplicationItem.then(itemInfo => {
return itemInfo instanceof PortalItem
? itemInfo.fetchData()
: undefined;
})
: promiseUtils.resolve();

const loadPortal = portalSettings.fetch
? new Portal().load()
: promiseUtils.resolve();
Expand All @@ -229,7 +227,6 @@ class ApplicationBase {
portalResponse,
checkAppAccessResponse
] = applicationArgs;

const applicationItem = applicationItemResponse
? applicationItemResponse.value
: null;
Expand Down Expand Up @@ -356,7 +353,6 @@ class ApplicationBase {
};

return promiseUtils.eachAlways(promises).catch((itemArgs) => itemArgs).then((itemArgs) => {
//.always(itemArgs => {
const webMapResponses = itemArgs.webMap.value;
const webSceneResponses = itemArgs.webScene.value;
const groupInfoResponses = itemArgs.groupInfo.value;
Expand Down Expand Up @@ -510,14 +506,14 @@ class ApplicationBase {
return units;
}

private _queryGroupInfo(groupId: string, portal: Portal): IPromise<any> {
private async _queryGroupInfo(groupId: string, portal: Portal): Promise<__esri.PortalQueryResult> {
const params = new PortalQueryParams({
query: `id:"${groupId}"`
});
return portal.queryGroups(params);
return await portal.queryGroups(params) as __esri.PortalQueryResult;
}

private _loadItem(id: string): IPromise<PortalItem> {
private _loadItem(id: string): Promise<PortalItem> {
const item = new PortalItem({
id
});
Expand Down
Loading

0 comments on commit 20a8991

Please sign in to comment.