Implements persistence for Events, and snapshot loading #17
Conversation
imabdulbasit
changed the title
jbearer
left a comment
jbearer
left a comment
There was a problem hiding this comment.
I have a few suggestions but I think the only blocker is the question about computing/storing the stake for the full node set
| // Mark all delegations to this node as exits | ||
| let result = sqlx::query( | ||
| "UPDATE delegation | ||
| SET unlocks_at = $1, withdrawal_amount = '0' | ||
| WHERE delegator = $2 AND node = $3", | ||
| ) | ||
| .bind(withdrawal.available_time as i64) | ||
| .bind(withdrawal.delegator.to_string()) | ||
| .bind(withdrawal.node.to_string()) | ||
| .execute(&mut **tx) | ||
| .await?; |
There was a problem hiding this comment.
It's a bit unfortunate that by breaking up the diff into one event for each wallet, this becomes one UPDATE for each wallet when it could be a single statement with just WHERE node = $. This is an issue with the design, since we use the same event stream for updating our own database as for updating clients...but there is a separate client for each wallet, while there is only one database, so the database become a bottleneck.
It seems like maybe we should have storage handle a new type of update, WalletsDiff, which are events generated that affect the entire set of wallets, not just one at at time. Then we could have a diff like NodeExited(address) without specifying any particular delegator. But anyways, this can be left for future work.
This PR implements SQLITE persistence for events. It includes migration for all the tables needed.
It saves the genesis l1 block, stores all the diffs and loads the finalized snapshot.