Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] l10n_br Account Invoice Merge Test #56

Merged
merged 1 commit into from
Dec 11, 2023
Merged

[14.0][ADD] l10n_br Account Invoice Merge Test #56

merged 1 commit into from
Dec 11, 2023

Conversation

MateusONunes
Copy link

No description provided.

@antoniospneto
Copy link

antoniospneto commented Dec 6, 2023

@MateusONunes eu acho que o amend ali dos commits falhou, agora você pode tentar o rebase interativo para fazer um squash dos 4 commits em um só, você pode tentar usando rebase interativo, o comando fica assim: git rebase -i HEAD~4
uma tela vai abrir e você marca quais commit vc quer fazer squash ( juntar com o commit de cima)

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (14.0-add-l10n_br_account_invoice_merge@d66eaf2). Click here to learn what that means.

Additional details and impacted files
@@                            Coverage Diff                            @@
##             14.0-add-l10n_br_account_invoice_merge      #56   +/-   ##
=========================================================================
  Coverage                                          ?   88.77%           
=========================================================================
  Files                                             ?      684           
  Lines                                             ?    26818           
  Branches                                          ?     2950           
=========================================================================
  Hits                                              ?    23809           
  Misses                                            ?     2129           
  Partials                                          ?      880           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MateusONunes
Copy link
Author

Obrigado @antoniospneto, fiz as correções, agora parece estar tudo ok.

@MateusONunes
Copy link
Author

PR pronta para revisão

cc @marcelsavegnago

Comment on lines 1 to 2
# Copyright 2023 - Mateus ONunes <[email protected]>
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
Copy link

@antoniospneto antoniospneto Dec 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eu não achei o link da referencia, mas pela boa pratica da OCA, não se coloca copyright nos arquivos __init__.py por eles serem muito simples.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muito Obrigado @antoniospneto, já apliquei a correção.

@marcelsavegnago marcelsavegnago merged commit 2026568 into Escodoo:14.0-add-l10n_br_account_invoice_merge Dec 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants