Consolidate --noti-bg and --noti-bg-alpha in a single variable #672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The values are put together in --noti-bg-normal. In places where the alpha value differs, GTK 3.0's alpha() function is used to change it. Since SASS also has its own alpha() function unrelated to GTK's, it causes issues in compilation. Implement a custom function which generates the function properly in the final CSS. They are now indirectly used and not removed for backwards compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I prefer having a minimal CSS, and having it synced to GTK's colorscheme, so I use GTK's CSS variables:
@window_bg_color,@window_fg_color, etc. These colors are inrgb()or a similar format, which makes it not possible to set--noti-bgto.It's also a matter of inconsistency; all colors are in
rgb()format, except--noti-bg. It is simply a set of three comma-separated values.Digging through the scss file and doing my due research, I created a new variable,
--noti-bg-normal, which used the color equivalent torgba(var(--noti-bg), var(--noti-bg-alpha)). Used it wherever applicable.There was also this one instance where the alpha value was constant. I decided to use GTK's
alpha(), but found out that it is already used by SASS. Thusly, I had to create a function which generated the requiredalpha()code upon compilation.I guess its safe to say that
--noti-bgand--noti-bg-alphacan be marked as deprecated.