Fix clang-apply-replacements flag detection#4844
Open
Rahmi-serag wants to merge 1 commit into
Open
Conversation
Rahmi-serag
force-pushed
the
fix/4768-clang-apply-replacements-stderr
branch
from
190fd14 to
9251255
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4768.
CodeChecker detects whether clang-apply-replacements supports --ignore-insert-conflict by parsing the --help output.
Previously only stdout was checked. Some LLVM/Clang versions may emit help output to stderr, so CodeChecker could fail to detect the supported option.
This change checks the combined stdout and stderr output.
Added unit tests for detecting the flag from both stdout and stderr.
Tested with:
REPO_ROOT="$PWD" PYTHONPATH="$PWD/analyzer:$PWD/build/CodeChecker/lib/python3:$PWD" pytest -q analyzer/tests/unit/test_analyzer_types.py