-
Notifications
You must be signed in to change notification settings - Fork 460
Add error on thrift version mismatch, add rebuild script. #4806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
feyruzb
wants to merge
6
commits into
Ericsson:master
Choose a base branch
from
feyruzb:chore/thrift-version-check-on-make-package
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+70
−2
Open
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
55c9b9c
add error on thrift version mismatch, add rebuild script
feyruzb e659203
change source of truth to version.py
feyruzb ce701b7
fix wrong script calling prompt
feyruzb 53cfd75
fix: move script to appropriate locaiton
feyruzb f2bc11d
fix: add another source of api comparison, remove build of package
feyruzb 53e10aa
chore: add .sh to pylint ignore-patterns
feyruzb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| #!/bin/bash | ||
|
|
||
| set -e # Exit on any error | ||
|
|
||
| echo "Starting CodeChecker Thrift rebuild process..." | ||
|
|
||
| # Resolve the repository root from the script's location. | ||
| SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" | ||
| REPO_ROOT="$(cd "$SCRIPT_DIR/../.." && pwd)" | ||
|
|
||
| # check if which enviroment to create is passed as an argument. | ||
| if [[ "$1" == "venv" || "$1" == "venv_dev" ]]; then | ||
| ENV_TYPE="$1" | ||
| else | ||
| echo "Error: You must specify 'venv' or 'venv_dev' as the first argument." | ||
| echo "Usage: $0 <venv|venv_dev>" | ||
| exit 1 | ||
| fi | ||
|
|
||
| # Step 1: Build the API | ||
| echo "Step 1: Building API..." | ||
| cd "$REPO_ROOT/web/api" | ||
| make build | ||
|
|
||
| # Step 2: Execute the main rebuild process | ||
| echo "Step 2: Executing main rebuild..." | ||
| cd "$REPO_ROOT" | ||
|
|
||
| # Deactivation of virtual enviroment | ||
| echo "Deactivating current environment..." | ||
| if command -v deactivate &> /dev/null; then | ||
| deactivate 2>/dev/null || true | ||
| fi | ||
|
|
||
| # Resetting the package-lock.json just in case | ||
| echo "Resetting package-lock.json..." | ||
| git checkout master -- "$REPO_ROOT/web/server/vue-cli/package-lock.json" | ||
| git reset HEAD "$REPO_ROOT/web/server/vue-cli/package-lock.json" | ||
|
|
||
| # Cleaning | ||
| echo "Cleaning previous builds..." | ||
| make clean | ||
| make "clean_${ENV_TYPE}" | ||
|
|
||
| # Creating new virtual environment | ||
| echo "Creating new virtual environment ($ENV_TYPE)..." | ||
| make "$ENV_TYPE" | ||
|
|
||
| echo "Building package..." | ||
| make package | ||
|
|
||
| # Again just in case | ||
| echo "Activating virtual environment and setting PATH..." | ||
| source "$REPO_ROOT/${ENV_TYPE}/bin/activate" | ||
| export PATH="$REPO_ROOT/build/CodeChecker/bin:$PATH" | ||
|
|
||
| echo "CodeChecker rebuild completed successfully!" | ||
| echo "You can now use CodeChecker commands." |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.