[fix] Blank page on invalid session token#4622
Merged
Merged
Conversation
When the browser has an auth session token that is not found on server side, then a blank page was loaded. As a workaround the user had to manually clear the token from the browser and reload the page. Now we redirect the user back to the login page when this situation occurs. The problem was that the "authParams" was cached in a state that its "sessionStillActive" field is false. Now these auth parameters are not cached but loaded from the server.
Discookie
approved these changes
Jul 9, 2025
Contributor
Discookie
left a comment
Discookie
left a comment
There was a problem hiding this comment.
Some way to test this case would be nice, but otherwise LGTM.
gulyasgergely902
approved these changes
Jul 9, 2025
Contributor
Author
|
@Discookie GUI tests are not stable, unfortunately, but I agree. We should test this in the future. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the browser has an auth session token that is not found on server side, then a blank page was loaded. As a workaround the user had to manually clear the token from the browser and reload the page. Now we redirect the user back to the login page when this situation occurs.
The problem was that the "authParams" was cached in a state that its "sessionStillActive" field is false. Now these auth parameters are not cached but loaded from the server.