Skip to content

[fix] Fix updating fixed_at time #4621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bruntib merged 1 commit into from
Jul 16, 2025
Merged

[fix] Fix updating fixed_at time #4621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,12 @@ test_unit_cov_in_env:
BUILD_DIR=$(BUILD_DIR) $(MAKE) -C $(CC_ANALYZER) test_unit_cov_in_env
BUILD_DIR=$(BUILD_DIR) $(MAKE) -C $(CC_WEB) test_unit_cov_in_env

test_functional:
test_functional: test_analyzer_functional test_web_functional

test_analyzer_functional:
BUILD_DIR=$(BUILD_DIR) $(MAKE) -C $(CC_ANALYZER) test_functional

test_web_functional:
BUILD_DIR=$(BUILD_DIR) $(MAKE) -C $(CC_WEB) test_functional

test_functional_in_env:
Expand Down
4 changes: 2 additions & 2 deletions web/server/codechecker_server/api/mass_store_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1130,7 +1130,7 @@ def get_missing_file_ids(report: Report) -> List[str]:
# rules, only review status source code comments
if old_report and old_report.review_status in \
['false_positive', 'intentional']:
fixed_at = old_report.review_status_date
fixed_at = old_report.fixed_at
else:
fixed_at = run_history_time

Expand Down Expand Up @@ -1322,7 +1322,7 @@ def get_skip_handler(
# rules, only review status source code comments
if old_report and old_report.review_status in \
['false_positive', 'intentional']:
fixed_at = old_report.review_status_date
fixed_at = old_report.fixed_at
else:
fixed_at = run_history_time

Expand Down
5 changes: 2 additions & 3 deletions web/tests/functional/review_status/test_review_status.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,14 +885,13 @@ def get_report():
self.assertEqual(report.fixedAt, fixed_at)

# A reopened and false positive report gets its "fixed at" date from
# ReviewStatus table. This is the date when the false positive review
# status was assigned to this bug.
# where the false positive status firstly given.

setup_test_project(3)
report = get_report()
self.assertEqual(report.detectionStatus, DetectionStatus.REOPENED)
self.assertEqual(report.reviewData.status, ReviewStatus.FALSE_POSITIVE)
self.assertNotEqual(report.fixedAt, fixed_at)
self.assertEqual(report.fixedAt, fixed_at)
Copy link
Copy Markdown
Contributor

@bruntib bruntib Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, modify the explanatory comment above this section accordingly.


# Setting its review status to confirmed makes it outstanding.

Expand Down
Loading