-
Notifications
You must be signed in to change notification settings - Fork 460
List enabled checkers in CLI: CodeChecker cmd runs #4468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
73ff6af
3ec795f
7787aa9
9d63a86
27704e2
1d6697f
25bb553
0936c70
28bb6a9
d24cb1d
5998c90
4c1b942
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -19,6 +19,7 @@ | |||
| import sys | ||||
| import shutil | ||||
| import time | ||||
| import json | ||||
| from typing import Dict, Iterable, List, Optional, Set, Tuple | ||||
|
|
||||
| from codechecker_api.codeCheckerDBAccess_v6 import constants, ttypes | ||||
|
|
@@ -639,6 +640,48 @@ def handle_list_runs(args): | |||
|
|
||||
| runs = get_run_data(client, run_filter, sort_mode) | ||||
|
|
||||
| if hasattr(args, 'enabled_checkers') and args.enabled_checkers: | ||||
| enabled_checkers: Dict[str, List[str]] = {} | ||||
| for run in runs: | ||||
| info_list: List[ttypes.AnalysisInfo] = client.getAnalysisInfo( | ||||
| ttypes.AnalysisInfoFilter(runId=run.runId), | ||||
| constants.MAX_QUERY_SIZE, | ||||
| 0) | ||||
| for info in info_list: | ||||
| analyzers = info.checkers.keys() | ||||
| for analyzer in analyzers: | ||||
| if analyzer not in enabled_checkers: | ||||
| enabled_checkers[analyzer] = [] | ||||
|
|
||||
| checkers = info.checkers.get(analyzer, {}) | ||||
| for checker in checkers: | ||||
| if checkers[checker].enabled: | ||||
| enabled_checkers[analyzer].append(checker) | ||||
|
|
||||
| if args.output_format == 'plaintext': | ||||
| for analyzer, checkers in enabled_checkers.items(): | ||||
| print(analyzer + ":") | ||||
| for checker in checkers: | ||||
| print(" " + checker) | ||||
| elif args.output_format == 'csv': | ||||
| separator = ';' | ||||
| print("Analyzer" + separator + "Checker") | ||||
| for analyzer, checkers in enabled_checkers.items(): | ||||
| for checker in checkers: | ||||
| print(analyzer + separator + checker) | ||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please, use the standard |
||||
| elif args.output_format == 'json': | ||||
| print(json.dumps(enabled_checkers, indent=4)) | ||||
| elif args.output_format == 'table': | ||||
| header = ['Analyzer', 'Checker'] | ||||
| rows = [ | ||||
| (analyzer, checker) | ||||
| for analyzer, checkers in enabled_checkers.items() | ||||
| for checker in checkers] | ||||
| print(twodim.to_str(args.output_format, header, rows)) | ||||
| else: | ||||
| LOG.error("Unsupported output format: %s", args.output_format) | ||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of introducing a separate if block for |
||||
| return | ||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding return here is totally unnecessary.
Suggested change
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @xb058t Please do as @cservakt suggested and merge the enabled-checkers processing starting at line 684. Also please add the enabled checkers list when [INFO 2026-02-13 15:50] - Checking for local valid sessions. |
||||
|
|
||||
| if args.output_format == 'json': | ||||
| # This json is different from the json format printed by the | ||||
| # parse command. This json converts the ReportData type report | ||||
|
|
@@ -682,6 +725,7 @@ def handle_list_runs(args): | |||
| codechecker_version)) | ||||
|
|
||||
| print(twodim.to_str(args.output_format, header, rows)) | ||||
| return | ||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The explicit 'return' at the end of the function is unnecessary in Python.
Suggested change
|
||||
|
|
||||
|
|
||||
| def handle_list_results(args): | ||||
|
|
||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.