Skip to content

Fix a crash where config handlers were built with missing binaries #4241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bruntib merged 1 commit into from
May 16, 2024
Merged

Fix a crash where config handlers were built with missing binaries #4241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions analyzer/codechecker_analyzer/analyzer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,12 +184,16 @@ def perform_analysis(args, skip_handlers, rs_handler: ReviewStatusHandler,
# TODO: Its perfectly reasonable for an analyzer plugin to not be able to
# build their config handler if the analyzer isn't supported in the first
# place. For now, this seems to be okay, but may not be later.
# Even then, if we couldn't get hold of the analyzer binary, we can't do
# anything.
errored_config_map = analyzer_types.build_config_handlers(
args, [x for (x, _) in errored])
args,
[x for (x, _) in errored
if analyzer_types.supported_analyzers[x].analyzer_binary()])

no_checker_err_analyzers = \
[a for (a, _) in errored
if not __has_enabled_checker(errored_config_map[a])]
[analyzer for analyzer, config_h in errored_config_map.items()
if not __has_enabled_checker(config_h)]

errored = [(an, msg) for an, msg in errored
if an not in no_checker_err_analyzers]
Expand Down
3 changes: 3 additions & 0 deletions analyzer/codechecker_analyzer/analyzers/analyzer_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,9 @@ def build_config_handlers(args, enabled_analyzers):
analyzer_config_map = {}

for ea in enabled_analyzers:
assert supported_analyzers[ea].analyzer_binary(), \
"At this point, we should've checked if this analyzer has a " \
"binary!"
config_handler = supported_analyzers[ea].construct_config_handler(args)
analyzer_config_map[ea] = config_handler

Expand Down