Revert "Don't emit a missing gcc warning if no checkers are enabled"#4238
Closed
bruntib wants to merge 1 commit into
Closed
Revert "Don't emit a missing gcc warning if no checkers are enabled"#4238bruntib wants to merge 1 commit into
bruntib wants to merge 1 commit into
Conversation
This reverts commit 7b49263.
Szelethus
requested changes
May 7, 2024
Contributor
Szelethus
left a comment
Szelethus
left a comment
There was a problem hiding this comment.
Care to elaborate as to why? I recall a crash being mentioned in person.
whisperity
added
analyzer 📈
Contributor
|
Note An equivalent copy of this revert, although unreviewed, is reachable from |
Szelethus
added a commit
to Szelethus/codechecker
that referenced
this pull request
May 8, 2024
Original patch (that itroduces the crash): Ericsson#4179 Revert attempt in Ericsson#4238. The crash occurs because the original patch tries to create config handlers even if they are not supported. This is playing with fire already, but the crash occured when not even the analyzer binary is found. In this patch, these analyzers are skipped from checking if they have any checkers enabled.
Contributor
Author
|
Fixed by #4241 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 7b49263.