chore(config): [clangsa][clang-tidy] Fix dead doc_urls in checker labels#4214
Merged
bruntib merged 2 commits intoApr 25, 2024
Merged
Conversation
6cb5db3 to
da973bb
Compare
…ot available upstream anymore
da973bb to
334ddca
Compare
334ddca to
ea758a6
Compare
bruntib
approved these changes
Apr 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the URLs for checkers which are no longer available upstream. Changes created mostly by applying #4207 and some manual review following that.
I deleted the checkers from the configuration which seemingly never existed in a release:
was introduced in llvm/llvm-project@8a8f77c, but subsequently removed and renamed ascppcoreguidelines-avoid-capture-default-when-capturing-thiscppcoreguidelines-misleading-capture-default-by-valuein llvm/llvm-project@eedbe81. Both of these commits happened betweenllvmorg-17-init(17.trunk branch-off) andllvmorg-17.0.0-rc1, thus there isn't a valid release that contained this check under this name.. This checker never actually existed under this name, even though the documentation was previously extant at https://clang.llvm.org/extra/clang-tidy/checks/linuxkernel/must-use-errs.html. The checker was introduced in llvm/llvm-project@fc8c65b with the file namelinuxkernel-must-use-errsMustCheckErrs[Check.(cpp|h)]and checker namelinuxkernel-must-check-errs(this is the name used in Tidy!), but with the broken documentation "name".linuxkernel-must-use-errsThus, the name of the checker and the name of the documentation does not line up.have alinuxkernel-must-use-errsseverityand thedoc_urlset, even though there never was a checker that reported under this name.linuxkernel-must-check-errs, which previously did not have the rightdoc_urlset.linuxkernel-must-check-errsdocumentation file name llvm/llvm-project#88655