[cmd] Restructure static HTML generation#4168
Merged
Merged
Conversation
bruntib
added
enhancement 🌟
CLI 💻
bruntib
force-pushed
the
static_html
branch
2 times, most recently
from
c5c41a2 to
08dab9c
Compare
cservakt
reviewed
Apr 10, 2024
| encoding="utf-8", | ||
| errors="ignore") | ||
| process.communicate() | ||
| print(process.communicate()) |
Collaborator
There was a problem hiding this comment.
I am not sure it is necessary to print here.
Comment on lines
+309
to
+315
| 'checker-name': data['report']['checker']['name'], | ||
| 'checker-url': data['report']['checker']['url'], | ||
| 'line': data['report']['line'], | ||
| 'message': data['report']['message'], | ||
| 'review-status': data['report']['reviewStatus'], | ||
| 'severity': data['report']['severity'], | ||
| 'bug-path-length': len(data['report']['events']) |
Collaborator
There was a problem hiding this comment.
Why is the props of data['report'] validating not necessary anymore?
Contributor
Author
There was a problem hiding this comment.
The self._get_html_reports() that generates these reports ensures that these members can't be None.
vodorok
approved these changes
Apr 10, 2024
Contributor
vodorok
left a comment
vodorok
left a comment
There was a problem hiding this comment.
I stand beside my comment about the let <-> var usage that I made on your other pr. Otherwise LGTM (But I am not a js expert). Also validated on a large report folder, and it paginated the reports for me.
bruntib
force-pushed
the
static_html
branch
2 times, most recently
from
980d7dd to
5bbfe2c
Compare
cservakt
approved these changes
Apr 11, 2024
Collaborator
cservakt
left a comment
cservakt
left a comment
There was a problem hiding this comment.
Thanks for the feature! Looks good to me now.
"CodeChecker parse <report_dir> -e html -o html" command generates a static HTML page showing all reports in the report directory. If the report dir is too big, then the generated HTML is too big and the browser freezes while loading it. In this commit the logic of the statis HTML page has been restructured in a way, that the reports are not HTML table elements automatically, but first they are stored in a JS object. Only those reports are inserted to the DOM tree that are currently visible based on the sorting and paging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"CodeChecker parse <report_dir> -e html -o html" command generates a static HTML page showing all reports in the report directory. If the report dir is too big, then the generated HTML is too big and the browser freezes while loading it.
In this commit the logic of the statis HTML page has been restructured in a way, that the reports are not HTML table elements automatically, but first they are stored in a JS object. Only those reports are inserted to the DOM tree that are currently visible based on the sorting and paging.