Endpoints for module-level C++ metric types#718
Conversation
|
@intjftw In my view (and as discussed on the previous meetings), there are 3 type of metrics, but 2 of them are really similar, so they can be merged.
File and module related metrics are basically the same, as CodeCompass identifies both of them with a file ID. I see no reason for differentiate between them, and this would only introduce code redundancy. On the other hand, we discussed the additional need for a higher abstraction level endpoint which does not receive an ASTNodeID or a FileID as an input parameter, but a file / directory path instead. Then, all file and AST node related metrics under that path should be returned. So e.g. if the path is module path, I would like to get:
|
mcserep
left a comment
There was a problem hiding this comment.
Generally looks okay, with some refactoring required.
Will start functional testing now.
mcserep
left a comment
There was a problem hiding this comment.
During functional testing, I discovered some further issues.
mcserep
left a comment
There was a problem hiding this comment.
Apart from the mentioned issues, looks good, ready to merge after fix 🚀
As we discussed, endpoints for module-level C++ metric types are also required. I added a new endpoint to query all available module-level metric types and all stored metrics for one module. There are no module-level metrics implemented for now, so testing is difficult.
@mcserep please help me out on what else we might need, and how should I modify the endpoint if needed.