Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new Enzyme-JAX with new LLVM #975

Closed
wants to merge 4 commits into from
Closed

Conversation

giordano
Copy link
Member

Let's see how far we get.

@giordano
Copy link
Member Author

@avik-pal only test failures are in sharding, can you please take a look?

@avik-pal
Copy link
Collaborator

avik-pal commented Mar 20, 2025

locally building to test. But from a look at the failures, it seems the propagation algorithm has undergone some changes

@avik-pal
Copy link
Collaborator

the non-jll tests can be ignored for now

@giordano
Copy link
Member Author

Just to know, is this ready to go or do you expect to do something else? Do we want to update Enzyme-JAX again? There are a bunch of more fixes we want soon. CC @wsmoses.

Also, I'd prefer to leave the Julia changes for a separate PR, having the "CI" jobs failing is problematic for most of the other PRs, we can live with the local build failing only.

@avik-pal
Copy link
Collaborator

yeah in that case let's get only the jll changes in and I will do the julia changes with the jll bump

@wsmoses
Copy link
Member

wsmoses commented Mar 20, 2025

per latency, concurrently starting the jll in the bg [on main, so we'll discard this PR after checking tests pass]

@wsmoses
Copy link
Member

wsmoses commented Mar 20, 2025

so @avik-pal feel free to do the julia changes now

@giordano
Copy link
Member Author

Superseded by #984.

@giordano giordano closed this Mar 20, 2025
@giordano giordano deleted the mg/enzyme-jax branch March 20, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants