Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backend tls #885

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add backend tls #885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2dc75bb
Add backend tls
wsmoses Mar 12, 2025
d24d09b
Apply suggestions from code review
giordano Mar 12, 2025
c0ec6dc
Update ext/ReactantCUDAExt.jl
giordano Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ext/ReactantCUDAExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,9 @@ function ka_with_reactant(ndrange, workgroupsize, obj, args...)

# figure out the optimal workgroupsize automatically
if KA.workgroupsize(obj) <: KA.DynamicSize && workgroupsize === nothing
if !Reactant.Compiler.PartitionKA[] || raising()
if !Reactant.Compiler.PartitionKA[] ||
raising() ||
Reactant.Compiler.backend() in ("cpu", "tpu")
threads = prod(ndrange)
else
config = CUDA.launch_configuration(kernel.fun; max_threads=prod(ndrange))
Expand Down
34 changes: 34 additions & 0 deletions src/Compiler.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,6 +700,38 @@ function raising!(f, is_raising::Bool)
end
end

function activate_backend!(backend::String)
stack = get!(task_local_storage(), :reactant_backend) do
String[]
end
push!(stack, backend)
return nothing
end

function deactivate_backend!(backend::String)
key = :reactant_backend
backend === last(task_local_storage(key)) ||
error("Deactivating wrong Reactant backend context")
return pop!(task_local_storage(key))
end

function backend(; throw_error::Bool=true)
key = :reactant_backend
if !(haskey(task_local_storage(), key) && !Base.isempty(task_local_storage(key)))
throw_error && error("No Reactant backend context")
end
return last(task_local_storage(key)::Vector{String})
end

function backend!(f, backend::String)
activate_backend!(backend)
try
return f()
finally
deactivate_backend!(backend)
end
end

function compile_mlir!(
mod,
f,
Expand Down Expand Up @@ -747,12 +779,14 @@ function compile_mlir!(
end
is_raising = raise isa String || raise
activate_raising!(is_raising)
activate_backend!(backend)

mlir_fn_res = try
Reactant.TracedUtils.make_mlir_fn(
f, args, fn_kwargs, "main", true; input_shardings, runtime
)
finally
deactivate_backend!(backend)
deactivate_raising!(is_raising)
deactivate_sdycache!(sdycache)
deactivate_callcache!(callcache)
Expand Down