Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Disable failing macOS-13 jobs #870

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

giordano
Copy link
Member

@giordano giordano commented Mar 9, 2025

Ref: #867.

I'm not particularly happy about this, but short of having someone to fix the issue above in this way we can have green CI back.

@giordano giordano force-pushed the mg/disable-intel-macos branch from 9a37a40 to 971dc66 Compare March 9, 2025 21:29
@wsmoses wsmoses self-requested a review March 9, 2025 21:33
Copy link
Member

@wsmoses wsmoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this for now, and presume you can make an issue to remind ourselves to come back to this post GB

@giordano
Copy link
Member Author

giordano commented Mar 9, 2025

There's #867 already (also referenced in the comment in the code) 🙂

@wsmoses
Copy link
Member

wsmoses commented Mar 9, 2025

ah got it!

Copy link

codecov bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.09%. Comparing base (b6ffc96) to head (971dc66).
Report is 544 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #870       +/-   ##
===========================================
+ Coverage   21.66%   41.09%   +19.42%     
===========================================
  Files          46      104       +58     
  Lines        8048    17325     +9277     
===========================================
+ Hits         1744     7119     +5375     
- Misses       6304    10206     +3902     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@giordano giordano merged commit ab3e852 into EnzymeAD:main Mar 10, 2025
52 checks passed
@giordano giordano deleted the mg/disable-intel-macos branch March 10, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants