Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Colon(::TracedRNumber, ::TracedRNumber) #839

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/TracedRNumber.jl
Original file line number Diff line number Diff line change
@@ -429,4 +429,6 @@ function Base.copysign(x::S, y::TracedRNumber{T}) where {S<:Number,T}
return copysign(TracedUtils.promote_to(TracedRNumber{S}, x), y)
end

Base.:(:)(start::T, stop::T) where {N<:Real,T<:TracedRNumber{N}} = UnitRange{T}(start, stop)

end # module TracedRNumberOverrides
17 changes: 17 additions & 0 deletions test/control_flow.jl
Original file line number Diff line number Diff line change
@@ -635,6 +635,23 @@ function call1(a, b)
return @trace _call1(x, y)
end

function for_traced_bounds(start, stop)
x = zero(start)
@trace for i in start:stop
x += i
end
return x
end

@testset "for: traced bounds" begin
start = 1
stop = 4
start_re = ConcreteRNumber(start)
stop_re = ConcreteRNumber(stop)

@test @jit(for_traced_bounds(start_re, stop_re)) == for_traced_bounds(start, stop)
end

@testset "call: basic" begin
a = rand(2, 3)
b = rand(2, 3)