Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: JLL changes for IFRT Shardings #770

Merged
merged 6 commits into from
Feb 19, 2025
Merged

Conversation

avik-pal
Copy link
Collaborator

JLL changes needed for #764

@avik-pal avik-pal requested a review from wsmoses February 19, 2025 05:57
@mofeing
Copy link
Collaborator

mofeing commented Feb 19, 2025

ah dammit, i forgot to format the code in my pr

do you mind doing that in this pr please?

@avik-pal
Copy link
Collaborator Author

yeah did that. I am trying to patch another bug before merging this

@avik-pal
Copy link
Collaborator Author

Tested with local JLL. merging

@avik-pal avik-pal merged commit 871790f into main Feb 19, 2025
29 of 33 checks passed
@avik-pal avik-pal deleted the ap/ifrt_shardings_jll_changes branch February 19, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants