-
Notifications
You must be signed in to change notification settings - Fork 22
Update JAX to commit 45065d569064392cee45a066f9f788fe29ee2cd8 #1418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@giordano this should get force pushed with the new commit right? [ironically the error here was a bug in jax proper, where we dont need to adapt, but presumably fixed on their end] |
|
Yes, but apparently this failed yesterday: https://github.com/EnzymeAD/Enzyme-JAX/actions/runs/17991295111/job/51181693038. I don't quite understand the error, my hunch is that this was a transient failure in querying github API |
|
Uhm, it failed again. I'll have a look. |
|
The error is Getting the commit message is actually working right, the text Edit: resolved by #1424 by avoiding going through |
1eb8516 to
156564e
Compare
|
|
ah yeah thats [a slightly different] upstream fix to the one we vendored earlier, we can remove our patch |
|
5843d29 to
e3d3330
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EnzymeJAX Benchmarks
| Benchmark suite | Current: f46d701 | Previous: 996b3e5 | Ratio |
|---|---|---|---|
scatter_sum / JaX / cpu / Primal |
0.00000456006700405851 s |
0.000004217056999914348 s |
1.08 |
scatter_sum / JaXPipe / cpu / Primal |
0.000004243713000323624 s |
0.000004099265101831406 s |
1.04 |
scatter_sum / JaX / tpu / Primal |
0.0001381269668985 s |
0.0001403182348993 s |
0.98 |
scatter_sum / JaXPipe / tpu / Primal |
0.0001453476698021 s |
0.0001510700437997 s |
0.96 |
This comment was automatically generated by workflow using github-action-benchmark.
Diff: jax-ml/jax@4455434...45065d5