Skip to content

Conversation

@giordano
Copy link
Member

@giordano giordano commented Sep 23, 2025

@wsmoses
Copy link
Member

wsmoses commented Sep 25, 2025

@giordano this should get force pushed with the new commit right? [ironically the error here was a bug in jax proper, where we dont need to adapt, but presumably fixed on their end]

@giordano
Copy link
Member Author

Yes, but apparently this failed yesterday: https://github.com/EnzymeAD/Enzyme-JAX/actions/runs/17991295111/job/51181693038. I don't quite understand the error, my hunch is that this was a transient failure in querying github API

@giordano
Copy link
Member Author

Uhm, it failed again. I'll have a look.

@giordano
Copy link
Member Author

giordano commented Sep 25, 2025

The error is

Error: Unable to process file command 'env' successfully.
Error: Invalid format 'Diff: https://github.com/jax-ml/jax/compare/4455434869812dfb7336b18f2e59a8690ba38e79...6c1760b695ee770c18f9a8b2f767398294a2c983'

Getting the commit message is actually working right, the text Diff: https://github.com/jax-ml/jax/compare/4455434869812dfb7336b18f2e59a8690ba38e79...6c1760b695ee770c18f9a8b2f767398294a2c983 comes from 1eb8516. I believe there's something going wrong when writing the multiline commit message into ${GITHUB_ENV}, the line Diff: https://github.com/jax-ml/jax/compare/4455434869812dfb7336b18f2e59a8690ba38e79...6c1760b695ee770c18f9a8b2f767398294a2c983 is somehow "interpreted"?

Edit: resolved by #1424 by avoiding going through ${GITHUB_ENV}.

@giordano giordano changed the title Update JAX to commit 6c1760b695ee770c18f9a8b2f767398294a2c983 Update JAX to commit 45065d569064392cee45a066f9f788fe29ee2cd8 Sep 25, 2025
@giordano
Copy link
Member Author

Error in patch: Error applying patch /__w/Enzyme-JAX/Enzyme-JAX/patches/xla.patch: in patch applied to /root/.bazel/external/xla/xla/backends/gpu/codegen/triton/BUILD: could not apply patch due to CONTENT_DOES_NOT_MATCH_TARGET, error applying change near line 262

@wsmoses
Copy link
Member

wsmoses commented Sep 25, 2025

ah yeah thats [a slightly different] upstream fix to the one we vendored earlier, we can remove our patch

@giordano
Copy link
Member Author

ERROR: /root/.bazel/external/triton/third_party/proton/BUILD: no such target '@@triton//third_party/proton:ProtonIRDialect': target 'ProtonIRDialect' not declared in package 'third_party/proton' defined by /root/.bazel/external/triton/third_party/proton/BUILD
ERROR: /__w/Enzyme-JAX/Enzyme-JAX/src/enzyme_ad/jax/BUILD:784:11: no such target '@@triton//third_party/proton:ProtonIRDialect': target 'ProtonIRDialect' not declared in package 'third_party/proton' defined by /root/.bazel/external/triton/third_party/proton/BUILD and referenced by '//src/enzyme_ad/jax:RegistryUtils'

@wsmoses
Copy link
Member

wsmoses commented Sep 26, 2025

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnzymeJAX Benchmarks

Benchmark suite Current: f46d701 Previous: 996b3e5 Ratio
scatter_sum / JaX / cpu / Primal 0.00000456006700405851 s 0.000004217056999914348 s 1.08
scatter_sum / JaXPipe / cpu / Primal 0.000004243713000323624 s 0.000004099265101831406 s 1.04
scatter_sum / JaX / tpu / Primal 0.0001381269668985 s 0.0001403182348993 s 0.98
scatter_sum / JaXPipe / tpu / Primal 0.0001453476698021 s 0.0001510700437997 s 0.96

This comment was automatically generated by workflow using github-action-benchmark.

@wsmoses wsmoses merged commit 6137ac9 into main Oct 17, 2025
13 of 24 checks passed
@wsmoses wsmoses deleted the jax-latest-commit branch October 17, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants