Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(label-config): added ability to specify label config #222

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

maira-samtek
Copy link
Collaborator

@maira-samtek maira-samtek commented Jul 12, 2024

Purpose

This PR adds ability to specify label config where user can select any prefix for the specific label
e.g.
for config: "[{"labelField":"ProductName","labelPrefix":"product","labelDelimiter":":"},{"labelField":"severity"},{"labelField":"accountId","labelDelimiter":"-","labelPrefix":"account"},{"labelField":"region"}]"
labels will be: [ 'product:Health', 'MEDIUM', 'account-zxxxzxzxxxxxx', 'us-east-1' ]

@maira-samtek maira-samtek requested a review from yonassrobi July 12, 2024 19:37
Copy link

@yonassrobi yonassrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maira-samtek maira-samtek merged commit da07afd into main Jul 15, 2024
5 checks passed
Copy link

🎉 This PR is included in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@maira-samtek maira-samtek deleted the zarate-product-config branch July 15, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants