Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(link-direction): added ability to chose link direction #218

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

maira-samtek
Copy link
Collaborator

Purpose

This PR enables the security hub sync to specify the link direction

Copy link

@yonassrobi yonassrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -339,7 +339,13 @@ export class SecurityHubJiraSync {
if (process.env.JIRA_LINK_TYPE) {
linkType = process.env.JIRA_LINK_TYPE;
}
await this.jira.linkIssues(newIssueInfo.key, issue_id, linkType);
const linkDirection = process.env.JIRA_LINK_DIRECTION ?? "inward";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I had to look up what the '??' expression does.

@maira-samtek maira-samtek merged commit 369d1a4 into main Jul 3, 2024
5 checks passed
Copy link

github-actions bot commented Jul 3, 2024

🎉 This PR is included in version 1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@maira-samtek maira-samtek deleted the zarate-link-direction branch July 10, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants