Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a longer wait to Cypress test #12019

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Add a longer wait to Cypress test #12019

merged 2 commits into from
Jan 23, 2025

Conversation

bangbay-bluetiger
Copy link
Contributor

@bangbay-bluetiger bangbay-bluetiger commented Jan 22, 2025

Description

Follow up to #12015. This test passes locally and in branches, but has been failing when merged to main. Adding a longer wait to see if that helps.

Also update todos and flags logs from latest main updates.


How to test

  1. yarn test to test locally

Notes

The failing test was changed from cy.contains("Archive").should("be.visible"); to cy.get('button:contains("Archive")').should("be.visible"); in #12009 because the former test was a false positive, since the text is also used in a table header. We want to test that the text is within a button in a table row.


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Copy link

codeclimate bot commented Jan 22, 2025

Code Climate has analyzed commit 85ae707 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 96.7% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@gmrabian gmrabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥲

@bangbay-bluetiger bangbay-bluetiger merged commit 805849a into main Jan 23, 2025
21 checks passed
@bangbay-bluetiger bangbay-bluetiger deleted the cypress-unarchive branch January 23, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants