Add best-practice axe rule set #12017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cy-by
requested review from
BearHanded,
braxex,
jessabean and
karla-vm
as code owners
|
Code Climate has analyzed commit 472bf38 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
bangbay-bluetiger
approved these changes
Jan 22, 2025
benmartin-coforma
approved these changes
Jan 22, 2025
gmrabian
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the best practice axe-core rule set. This rule set will improve future development as it will catch more avoidable mistakes.
I rant the tests locally with this new rule set and there were no error caught. I'm hoping that will also be the case in CI/CD of this PR.
How to test
Run tests locally, they should still pass.
Pre-review checklist