Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component tests refactor #12010

Merged
merged 22 commits into from
Jan 22, 2025
Merged

Component tests refactor #12010

merged 22 commits into from
Jan 22, 2025

Conversation

gmrabian
Copy link
Contributor

@gmrabian gmrabian commented Jan 21, 2025

Description

Based on MFP common tests refactor

Suggestion: When reviewing the code changes select the option to hide whitespace. This will filter out any indentation/reorganization changes due to nesting.
Screenshot 2025-01-22 at 9 36 26 AM


How to test

  • Unit tests pass in pipeline

Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

@gmrabian gmrabian changed the title Test updates Component tests refactor Jan 21, 2025
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 12108 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 12141 lines exceeds the maximum allowed for the inline comments feature.

@gmrabian gmrabian marked this pull request as ready for review January 21, 2025 20:55
@gmrabian gmrabian added the ready for review Ready for all the reviews! label Jan 21, 2025
karla-vm
karla-vm previously approved these changes Jan 22, 2025
Copy link
Collaborator

@karla-vm karla-vm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's some conflicts with main but otherwise this is good! 💯

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 11310 lines exceeds the maximum allowed for the inline comments feature.

Copy link

codeclimate bot commented Jan 22, 2025

Code Climate has analyzed commit 704fce8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 96.7% (0.0% change).

View more on Code Climate.

@gmrabian gmrabian requested a review from karla-vm January 22, 2025 15:58
Copy link
Contributor

@bangbay-bluetiger bangbay-bluetiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@gmrabian gmrabian merged commit 2805d50 into main Jan 22, 2025
19 checks passed
@gmrabian gmrabian deleted the test-updates branch January 22, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants