Add ability to delete custom analysis methods

[gmrabian]

Description

• Add analysis methods page to completion calculation
  • Determines if method is part of default, and then applies calculation with the applicable form
    • The calculateEntityCompletion method accepts an array of different forms, but it expects the data to fulfill every form, rather than being able to apply a specific form per dataset, so this was the best way I could see to do it
• Add logic to disable "submit" button on delete modal for non-end users and when form is locked (submitted)
• Add delete entity button and modal to DrawerReportPage

Related ticket(s)

CMDCT-4233

---

How to test

Deployed url

• Log in as a state user
• Create and enter a NAAAR
• Create a plan
• Go to Analysis Methods
• Add a custom analysis method
• Click the X button on the new method
  • Verify it opens the delete modal
  • Verify the text is relevant to analysis methods
  • Verify when you click the submit button in the modal it deletes that method
• Verify analysis methods completion statusing on the review and submit page when you have completed all methods, including adding custom methods

Navigate to a different drawer type page (in MCPAR you can create a plan and go to plan level indicators)

• Verify the delete button does not show up in those rows

Notes

---

Pre-review checklist

• I have added thorough tests, if necessary
• I have updated relevant documentation, if necessary
• I have performed a self-review of my code
• I have manually tested this PR in the deployed cloud environment

---

Pre-merge checklist

Review

• Product: This work has been reviewed and approved by product owner, if necessary

---

[JonHolman]

When I add multiple, then I hit the delete, from the modal I cannot confirm which one I hit delete on.

[JonHolman]

The columns are not lining up when I add a bunch with some different frequencies and descriptions.

[karla-vm]

This looks great! Statusing is working as expected, I was able to add and delete custom methods. One thing I noticed is that when you enter a custom method, the Plans utilizing this method question is not validating correctly, I'm able to save without clicking on a plan checkbox.

In terms of the styling, I played around a bit with adding an empty <Heading /> or a hidden <Button /> and it feels hacky... Your idea of converting this into a table sounds like the best approach for sure! I'll create a follow-up ticket for that refactoring work.

[gmrabian]

When I add multiple, then I hit the delete, from the modal I cannot confirm which one I hit delete on.

@JonHolman this is a good callout! The Figma also does not specify. Perhaps in the future we could add that as an enhancement but for now I am not going to add it to this work.

[bangbay-bluetiger]

Looks good to me! Comments are really nits.

[gmrabian]

thanks @bangbay-bluetiger! great feedback as always

[codeclimate]

Code Climate has analyzed commit 65646f5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 96.7% (0.0% change).

View more on Code Climate.