-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add help page and create report modal PCCM content #11528
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nitpicks, but I think you chose a good approach.
services/ui-src/src/forms/addEditMcparReport/addEditMcparReportWithoutYoY.json
Show resolved
Hide resolved
services/ui-src/src/forms/addEditMcparReport/addEditMcparReportWithoutYoY.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Echoing @benmartin-coforma 's comments, otherwise it looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ben got all the good nitpicks, looks good once they're resolved
Code Climate has analyzed commit 19d9081 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 95.8% (0.0% change). View more on Code Climate. |
Description
Add PCCM-related content to help page and create report modal
Open to suggestions on cleaner ways to put this together! I could do all the html in one block and it'd be shorter, though less readable
Related ticket(s)
CMDCT-3080
How to test
/help
/mcpar
Author checklist