Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help page and create report modal PCCM content #11528

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Conversation

gmrabian
Copy link
Contributor

@gmrabian gmrabian commented Dec 5, 2023

Description

Add PCCM-related content to help page and create report modal

Open to suggestions on cleaner ways to put this together! I could do all the html in one block and it'd be shorter, though less readable

Related ticket(s)

CMDCT-3080


How to test

  • Log in as a state user
  • Go to "Get Help" or /help
  • Open the new accordion and verify it matches the Figma
  • Go to the mcpar dashboard or /mcpar
  • Click to create a new report
  • Verify the last question with the PCCM radio now has hint content, and that the link in the hint opens the help page in a new tab

Author checklist

  • I have performed a self-review of my code

@gmrabian gmrabian marked this pull request as ready for review December 6, 2023 14:37
@gmrabian gmrabian added the ready for review Ready for all the reviews! label Dec 6, 2023
Copy link
Contributor

@benmartin-coforma benmartin-coforma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicks, but I think you chose a good approach.

services/ui-src/src/verbiage/pages/help.ts Outdated Show resolved Hide resolved
services/ui-src/src/verbiage/pages/help.ts Outdated Show resolved Hide resolved
services/ui-src/src/verbiage/pages/help.ts Outdated Show resolved Hide resolved
karla-vm
karla-vm previously approved these changes Dec 6, 2023
Copy link
Collaborator

@karla-vm karla-vm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Echoing @benmartin-coforma 's comments, otherwise it looks good!

BearHanded
BearHanded previously approved these changes Dec 6, 2023
Copy link
Contributor

@BearHanded BearHanded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ben got all the good nitpicks, looks good once they're resolved

Copy link

codeclimate bot commented Dec 6, 2023

Code Climate has analyzed commit 19d9081 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 95.8% (0.0% change).

View more on Code Climate.

@gmrabian gmrabian enabled auto-merge (squash) December 6, 2023 18:29
@gmrabian gmrabian merged commit beed7ce into main Dec 6, 2023
14 checks passed
@gmrabian gmrabian deleted the pccm-content-3080 branch December 6, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants