User Zustandification™️ #11527
Merged
User Zustandification™️ #11527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karla-vm
requested review from
BearHanded,
braxex and
cassandradanger
as code owners
benmartin-coforma
previously approved these changes
Dec 1, 2023
gmrabian
requested changes
Dec 4, 2023
There was a problem hiding this comment.
Requesting changes because: Two E2E cypress tests are failing in GitHub Actions and the same two fail for me locally.
Other notes:
I noticed we use this statement a lot when pulling in the user data to files:
useStore().user ?? {};
Is there a way we could make that logic part of the store / do we still need to optionally return the empty object? Just curious since it's used so often
|
Code Climate has analyzed commit f4c0cd8 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 95.8% (0.0% change). View more on Code Climate. |
gmrabian
approved these changes
Dec 7, 2023
benmartin-coforma
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converting the
UserContextstate management of MCR fromContext APItoZustand(following the patterns implemented in MFP).Related ticket(s)
CMDCT-2794
How to test
Running this locally, you should be able to log in, log out, and manage Banners (as an Admin) as usual.
Optionally: install the Redux Devtools Chrome extension or the Firefox Redux Devtools extension
userobject on the extension ✨Important updates
Author checklist
convert to a different template: test → val | val → prod