-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AV scan #11519
Fix AV scan #11519
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not tested, but this looks about right!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Climate has analyzed commit 2844ff5 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 96.0% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Our virus scan started failing after upgrading the lambda runtime to node 18 because node 16 and below included aws-sdkv2 and node18+ includes aws-sdkv3
V2 to V3 upgrade suggestion from this forum and confirmed by AWS announcement
Explanation of changes:
aws-sdk
to modulized@aws-sdk/client-s3
.promise()
on awaits and v3 does notclient.{commandType}(params)
syntax has changed toAWS-SDKv3 S3 docs
Related ticket(s)
CMDCT-3013
How to test
uploads-virus-scan-3013-attachments-446712541566
uploads-virus-scan-3013-avScan
-> Monitor tab -> View Cloudwatch logsCLEAN
tagVerify MCPAR template was tagged CLEAN
Download MCPAR Excel Workbook
on the homepage and ensure it downloads the xlsx fileAuthor checklist