Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a backfill script for previousRevisions, submissionCount #11516

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

benmartin-coforma
Copy link
Contributor

Description

Recent work has added the ability to count revisions and track previous submissions for MCPAR reports. This involved adding new properties to MCPAR metadata. Unfortunately, those properties will be missing from existing reports. This ETL script will add them.

Related ticket(s)

CMDCT-2265


How to test

  1. Checkout this branch
  2. Debug locally
  3. Create a MCPAR report
  4. Invoke the ETL locally
  5. Without stopping the app, check out branch admin-dash-3023
  6. Ensure the existing report behaves as expected

Important updates

n/a


Author checklist

  • I have performed a self-review of my code
  • I have added thorough tests, if necessary
  • [ ] I have updated relevant documentation, if necessary

@benmartin-coforma benmartin-coforma added the ready for review Ready for all the reviews! label Nov 9, 2023
@benmartin-coforma benmartin-coforma self-assigned this Nov 9, 2023
@benmartin-coforma benmartin-coforma marked this pull request as ready for review November 13, 2023 16:25
Copy link

codeclimate bot commented Nov 13, 2023

Code Climate has analyzed commit cda7778 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 96.0% (0.0% change).

View more on Code Climate.

Copy link
Collaborator

@karla-vm karla-vm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seen it work live! 💯 🚢

@benmartin-coforma benmartin-coforma merged commit 5bd2277 into main Nov 14, 2023
@benmartin-coforma benmartin-coforma deleted the mcpar-etl-2265 branch November 14, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants