[CMDCT-2] Fix clear prop hiding users answers when they click cancel but come back #11515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsummers1
requested review from
BearHanded,
braxex and
cassandradanger
as code owners
|
Code Climate has analyzed commit 6c58543 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 96.0% (0.0% change). View more on Code Climate. |
ntsummers1
added
ready for review
karla-vm
approved these changes
Nov 13, 2023
gmrabian
reviewed
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you edit a field when inside of a drawer or a modal and then click cancel, it would end up showing that field as edited (Though the backend still had its original answer). This can be very jarring to the user, so this PR fixes the clear prop thats causing this discrepancy!
Related ticket(s)
CMDCT-2
How to test
Create a MCPAR form
Go to Access Measures (Or any drawer form or modal form you want)
Create an Access Measure
Click edit Access Measure to reopen to modal.
Edit a text field
Click Cancel
Click edit Access Measure again
See your text field has your original answer!
Author checklist