[CMDCT-3032] Fix text fields not saving in nested choices if not last field in choicelist

[ntsummers1]

Description

Important Note!

While reviewing this, you'll see my videos with the Before and After. The before captures a state where the user is tabbing off the checkbox's child to another choice, and then moving to a different page before coming back. THIS IS NOT FIXED. I've tried friends. I really have. We need state management something fierce. That being said, what is fixed are all of the scenarios in the after column. Which are a heck of a lot better then before. Go ahead and repeat those on main and you'll see the difference. Nested fields were getting cleared for no reason when still on the same page. This solves that. For going to a different page though and coming back? I can't do it with out some real edge case spagehetti that would require so many tests. I tried writing those tests too. You don't want those tests and all those branches. It introduces too much complexity and variables. Revisit this when we have more time and zustand can be properly enacted.

---

If a user was to tab to a different checked answer when filling out a child choice, it would clear that child choice. This fixes it so other fields that were filled out won't be changed!

This really just removes code that didn't need to be there any longer and fixes the value being sent to what the form has it stored as.

Before

281254377-86266114-a6bf-400e-aec8-8eeb56927dad.mov

After

Screen.Recording.2023-11-14.at.11.06.35.AM.mov

Screen.Recording.2023-11-07.at.11.28.56.PM.mov

Screen.Recording.2023-11-07.at.11.57.18.PM.mov

Screen.Recording.2023-11-08.at.12.02.42.AM.mov

Related ticket(s)

CMDCT-3032

---

How to test

Create a Report
Navigate to C1.III.1 Uses of encounter data
Check Other Specify, fill out the text box
tab off to the next choice
click anywhere that is not in the choicelist (like to another page)
Come back and see its still there!

Go into B.X.7a Changes in Provider circumstances: Monitoring Plans
Play around and make sure its sending and filling out correctly as you clear and check things

Open MLR
Checkout the overlay section too!

---

Author checklist

• I have performed a self-review of my code
• I have added thorough tests, if necessary
• I have updated relevant documentation, if necessary

[gmrabian]

fix did not work for me locally 😱

[codeclimate]

Code Climate has analyzed commit a3b1f0f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 66.6% (90% is the threshold).

This pull request will bring the total coverage in the repository to 95.7% (-0.2% change).

View more on Code Climate.