-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MDCT-3023: MCPAR Admin Dashboard Update (UI Changes) #11511
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karla-vm
requested review from
BearHanded,
braxex and
cassandradanger
as code owners
November 2, 2023 20:48
Code Climate has analyzed commit 06dcca4 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 96.0% (0.0% change). View more on Code Climate. |
gmrabian
approved these changes
Nov 6, 2023
Open question: will existing reports work OK before any ETL? Or will the type changes cause issues? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bringing the
Unlock/Lock
admin functionality from the MLR dashboard to the MCPAR dashboard.Related ticket(s)
CMDCT-3023
How to test
[email protected]
You should see a version number column and a (disabled) Unlock button.
You should see the Unlock button is now enabled and functioning as expected.
Important updates
Author checklist
convert to a different template: test → val | val → prod