Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDCT-3023: MCPAR Admin Dashboard Update (UI Changes) #11511

Merged
merged 19 commits into from
Nov 13, 2023
Merged

Conversation

karla-vm
Copy link
Collaborator

@karla-vm karla-vm commented Nov 2, 2023

Description

Bringing the Unlock/Lock admin functionality from the MLR dashboard to the MCPAR dashboard.

Related ticket(s)

CMDCT-3023


How to test

  • Create a MCPAR report
  • Log in as [email protected]
  • Navigate to the MCPAR reports for the state you've created a report under

You should see a version number column and a (disabled) Unlock button.

  • Log back in as a state user
  • Submit the report
  • Log in as the admin again, navigate to that report

You should see the Unlock button is now enabled and functioning as expected.

Important updates


Author checklist

  • I have performed a self-review of my code
  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary

convert to a different template: test → val | val → prod

@karla-vm karla-vm marked this pull request as ready for review November 2, 2023 20:48
Copy link

codeclimate bot commented Nov 3, 2023

Code Climate has analyzed commit 06dcca4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 96.0% (0.0% change).

View more on Code Climate.

@benmartin-coforma
Copy link
Contributor

Open question: will existing reports work OK before any ETL? Or will the type changes cause issues?

@karla-vm karla-vm merged commit 9c1034d into main Nov 13, 2023
@karla-vm karla-vm deleted the admin-dash-3023 branch November 13, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants