-
Notifications
You must be signed in to change notification settings - Fork 3
Specified the robustness property to refer to consensus protocols with immediate finality #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
saltiniroberto
wants to merge
2
commits into
EntEthAlliance:master
from
saltiniroberto:improved-the-definition-of-robustness
Closed
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,7 +13,10 @@ In order alphabetically by `Label` then by `Term`, or just `Term` if there is no | |
|
|
||
| |Label | Term | Definition | | ||
| |------| ---------------------------------- | --------------- | | ||
| | CP | Liveness | Every correct propsed value will eventually be accepted by correct nodes. aka something good happens. | | ||
| | CP | Chain Agreement with Immediate Finality | At any point in time, for any two nodes `n1` and `n2`, either the blockchain of `n1` is a prefix of the blockchain of `n2` or the blockhain of `n2` is a prefix for the blockchain of `n1` | | ||
| | CP | Honest Chain Growth | For any point in time `t` and any node `n`, there exists a fine value `τ` such that the length of the blockchain of node `n` at time `t+τ` includes block proposed by honest nodes that were not included in the blockchain for node `n` at time `t`. | | ||
| | CP | Robust Consensus Protocol with Immediate Finality | A consensus protocol with immediate finality is robust if and only if it guarantees all of the following properties: <ul><li>Chain Agreement with Immediate Finality<li>Honest Chain Growth</ul> | | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should revisit the robustness definition here #14 before including it in any other document.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thi sis the liveness property |
||
| | CP | Liveness | Every correct propsed value will eventually be accepted by correct nodes. aka something good happens. | | ||
| | CP| Persistence | ?? | ||
| | CP | Safety | If a value is committed by a correct node, then that value will eventually be commited by all correct nodes. Two correct nodes will never commit to different values. aka nothing bad happens. | ||
| || Cryptographic Hash Function | A collision resistant hash function that cannot feasibly be reversed by a computationally bound adversary. | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this seems like more of a Ledger property in general not necessarily specific to consensus. Even if we consider this a consensus property, this "common prefix" attribute is, in fact, better defined as consistency instead of "chain agreement with immediate finality". The definition seems not complete either, should we not also consider the case when "at any point in time . . " both blockchains are identical?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the safety property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy to change the name if required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If two blockchains are identical then they are the prefix of each other. I will add this bit in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have pushed a new commit that clarifies this.