Skip to content

[WIP] Fix Invokable actions [JS Compatibility] #1964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sharjeelyunus
Copy link
Member

@sharjeelyunus sharjeelyunus commented Apr 21, 2025

This PR addresses issues where the following actions are not functioning correctly when used in JS

  • getLocation
  • executeCode
  • pickFiles
  • openPlaidLink
  • rateApp
  • updateBadgeCount
  • clearBadgeCount
  • executeConditionalAction
  • getNetworkInfo
  • checkPermission
  • bluetoothStartScan
  • bluetoothConnect
  • bluetoothDisconnect
  • bluetoothSubscribeCharacteristic
  • bluetoothUnsubscribeCharacteristic
  • sendVerificationCode
  • validateVerificationCode
  • resendVerificationCode

… with location data. Remove deprecated location handling from ScreenController.
@sharjeelyunus sharjeelyunus self-assigned this Apr 21, 2025
- Introduced FilePickerAction to handle file selection from gallery or files.
- Updated ScreenController to remove deprecated file manager references.
- Registered FilePickerAction in ActionInvokable for action handling.
- Adjusted imports in relevant files to integrate the new action.
@TheNoumanDev TheNoumanDev requested review from kmahmood74 and removed request for kmahmood74 April 21, 2025 22:19
sharjeelyunus and others added 3 commits April 24, 2025 17:08
- Added execution logic for PlaidLinkAction in the action framework.
- Removed deprecated PlaidLink handling from ScreenController.
- Updated ActionInvokable to include ActionType.openPlaidLink.
- Introduced error handling for Plaid link opening process.
- Updated ActionInvokable to include ActionType.updateBadgeCount and ActionType.clearBadgeCount.
- These additions enhance the action framework's capabilities for managing badge counts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants