Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Glances #284

Merged
merged 11 commits into from
Sep 24, 2024
Merged

Added Glances #284

merged 11 commits into from
Sep 24, 2024

Conversation

mcmikemn
Copy link
Collaborator

Added Glances, an open-source system cross-platform monitoring tool. It's like a light version of Prometheus.

I added it because Homepage has a widget for it and I wanted to see basic server stats from Homepage. (Homepage also has a widget for Prometheus, but it's far more basic - it's funny: Promethus is a more robsut metrics monitor but the Homepage widget is basic, Glances is a farily basic metrics monitor but the widget is more robust).

@mcmikemn mcmikemn self-assigned this Sep 24, 2024
@mcmikemn mcmikemn added the enhancement New feature or request label Sep 24, 2024
@EnigmaCurry
Copy link
Owner

EnigmaCurry commented Sep 24, 2024

https://github.com/nicolargo/glances/tree/24c87253595f9d3168afc26e82cfa464fc7523b9?tab=readme-ov-file#docker-the-cloudy-way

This example does use network mode host, but not privileged. Is privileged necessary?

Nevermind, it matters not because of the bind mounted socket gives them privileged access anyway.

@EnigmaCurry
Copy link
Owner

EnigmaCurry commented Sep 24, 2024

## Warning

This container has privileged access to your host, and full control of
Docker via bind mount socket. It also uses the docker flag
`network_mode: host`. This gives unlimited access to your host
network. You should not install this unless you completely trust this
service. To enforce the use of Traefik as your entrypoint, your
external firewall should block TCP ports 61208 and 61209.

@EnigmaCurry
Copy link
Owner

With the addition of the README warning above, I am happy with this as-is.

EnigmaCurry
EnigmaCurry previously approved these changes Sep 24, 2024
@mcmikemn
Copy link
Collaborator Author

I reduced priveleges, added alert, variablized bind mount to docker socket, updated readme.

You were already OK with this PR with only the alert added. Do you want to review my changes, @EnigmaCurry?

@mcmikemn
Copy link
Collaborator Author

Oh wait, I want to make one more change.

EnigmaCurry
EnigmaCurry previously approved these changes Sep 24, 2024
@mcmikemn mcmikemn merged commit 36b4347 into master Sep 24, 2024
@mcmikemn mcmikemn deleted the glances branch September 24, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants